Site editor: preload post and template lookups if needed #7695
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
src/wp-admin/site-editor.php
Outdated
| @@ -118,6 +118,10 @@ static function ( $classes ) { | |||
| ), | |||
| ); | |||
|
|
|||
| if ( ! empty( $_GET['postId'] ) ) { | |||
| $preload_paths[] = add_query_arg( 'context', 'edit', rest_get_route_for_post( $_GET['postId'] ) ); | |||
There was a problem hiding this comment.
This is lacking any sort of sanitization.
Also rest_get_route_for_post can return an empty string if no post is found, in which case one wouldn't want do add this to the array.
There was a problem hiding this comment.
Yes, the empty string check has already been added in GB.
There was a problem hiding this comment.
Should be fixed. Is get_post enough sanitisation?
ellatrix
changed the title
| $block_editor_context = new WP_Block_Editor_Context( array( 'name' => 'core/edit-site' ) ); | ||
| $context_settings = array( 'name' => 'core/edit-site' ); | ||
|
|
||
| if ( ! empty( $_GET['postId'] ) ) { |
There was a problem hiding this comment.
Let's verify that postId is an int value.
ellatrix
force-pushed
the
add/site-editor-preload-post
branch
from
b3481f1 to
fb43af1
Compare
See:
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.