mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tax Query: Allow querying for all posts with any term of a given taxonomy #7271
Draft
ockham
wants to merge
27
commits into
WordPress:trunk
Choose a base branch
from
ockham:add/tax-query-for-all-terms-in-taxonomy
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
4bcc0a5
Tax Query: Allow querying for all posts with any term of a given taxo…
ockham 6c90faf
Restore whitespace
ockham 15a7daf
...and remove spurious whitespace
ockham 28e6250
Tighten guard
ockham 55bc397
else should do here
ockham 9a04ce6
Make basic redirect work
ockham 7bf5979
A bit hacky
ockham 1c42f8b
Better?
ockham f17bf17
Revert "Better?"
ockham 03edd43
Re-use query
ockham 4d8f697
Proper teardown
ockham 8ddd012
Update test
ockham 5792517
Re-differentiate queries
ockham 2f94522
Change name of rewrite tag and permastruct
ockham 92e47b4
Add back dangling equals sign
ockham 3ba0584
Use only taxonomy= format for root tax archives
ockham ea1d6cc
Remove now-obsolete comment
ockham 81c0272
Match taxonomy name
ockham aa8675f
Change order of precedence
ockham 36ae684
Start adding some basic test coverage
ockham 9b68771
Make work with query_vars
ockham 12f5208
Simplify
ockham 772437f
Add ticket references
ockham 91ddfda
Add more test coverage
ockham 20e46d0
Rephrase for legibility
ockham 73b6712
Handle default category query correctly
ockham e767570
Add register_taxonomy flag
ockham File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing
()
here is a RegEx capturing group. WordPress really wants to retrieve a match from this RegEx that it'll use as the value in the query string; it'll automatically build a query string like this:?key=$matches[0]
, using the$matches
var resulting from applying the RegEx.Since we don't want to set any value, we work around this by providing a capturing group that will return the empty string, thus resulting in
?key=
.