Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce specificity of block style variation selector. #5917

Conversation

tellthemachines
Copy link
Contributor

Trac ticket: https://core.trac.wordpress.org/ticket/60312

Syncs WordPress/gutenberg#57659. This change will only be fully testable in core once the npm packages are updated, given that there's a matching specificity reduction in block library styles. Without that package update, core styles for the Button block may override some of its variation styles.


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Member

@felixarntz felixarntz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tellthemachines LGTM, though we should probably wait with the commit to do it at a similar time when the packages are synced.

Copy link
Member

@joemcgill joemcgill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, but I'm curious why the chaining was initially implemented here and if this risks introducing a style regression that this was meant to fix?

@tellthemachines
Copy link
Contributor Author

Thanks for the reviews folks!

I'm curious why the chaining was initially implemented here and if this risks introducing a style regression that this was meant to fix

Initially the chaining was meant to override some overly-specific block library styles. These have been progressively reduced in specificity, and the Button one that is changed in the Gutenberg PR was the last remaining style requiring the chaining. With that change, we're safe to remove the chaining too.

@mukeshpanchal27
Copy link
Member

The code looks fine, but I'm curious why the chaining was initially implemented here and if this risks introducing a style regression that this was meant to fix?

If someone override similar CSS selector in CSS file previously then it will not affect previously but after these changes it will get affected.

@getdave
Copy link
Contributor

getdave commented Jan 25, 2024

Note for release PHP syncing purposes we should delay committing this as per this comment.

@konicabulliz

This comment was marked as spam.

@liphajackson

This comment was marked as spam.

@tellthemachines
Copy link
Contributor Author

Committed in r57490.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

7 participants