-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce specificity of block style variation selector. #5917
Reduce specificity of block style variation selector. #5917
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tellthemachines LGTM, though we should probably wait with the commit to do it at a similar time when the packages are synced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but I'm curious why the chaining was initially implemented here and if this risks introducing a style regression that this was meant to fix?
Thanks for the reviews folks!
Initially the chaining was meant to override some overly-specific block library styles. These have been progressively reduced in specificity, and the Button one that is changed in the Gutenberg PR was the last remaining style requiring the chaining. With that change, we're safe to remove the chaining too. |
If someone override similar CSS selector in CSS file previously then it will not affect previously but after these changes it will get affected. |
Note for release PHP syncing purposes we should delay committing this as per this comment. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Committed in r57490. |
Trac ticket: https://core.trac.wordpress.org/ticket/60312
Syncs WordPress/gutenberg#57659. This change will only be fully testable in core once the npm packages are updated, given that there's a matching specificity reduction in block library styles. Without that package update, core styles for the Button block may override some of its variation styles.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.