Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix localization on install screen #5121

Closed
wants to merge 10 commits into from

Conversation

swissspidy
Copy link
Member

Works around issues with script localization happening too early because of blocks being registered.

Trac ticket: https://core.trac.wordpress.org/ticket/58696


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

@costdev
Copy link
Contributor

costdev commented Oct 6, 2023

@swissspidy Thanks for working on this! This appears to work for the password strength indicator but not for the Show/Hide button on interaction.

pr-5121-strength-indicator-works-but-button-does-not-on-interaction.mp4

@swissspidy
Copy link
Member Author

@costdev Weird, I cannot reproduce this. Did you perhaps navigate forward/backward in the browser or reload the install page when you recorded this, instead of starting install from scratch? The $_REQUEST could have been emptied.

Works fine for me:

Screen.Recording.2023-10-12.at.14.29.05.mov

@costdev
Copy link
Contributor

costdev commented Oct 13, 2023

@swissspidy Hmm, I'm not sure now. Might be worth getting another tester to check it in case it's maybe something going on locally for me.

@swissspidy
Copy link
Member Author

@SergeyBiryukov @ocean90 Would appreciate your review on this one so we can fix it in 6.5 🙏

Copy link

@jornp jornp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me:

Screen.Recording.2023-11-16.at.14.41.59.mov

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

@swissspidy
Copy link
Member Author

@swissspidy swissspidy closed this Jan 15, 2024
@swissspidy swissspidy deleted the fix/58696-l10n branch January 15, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants