-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix localization on install screen #5121
Conversation
@swissspidy Thanks for working on this! This appears to work for the password strength indicator but not for the Show/Hide button on interaction. pr-5121-strength-indicator-works-but-button-does-not-on-interaction.mp4 |
@costdev Weird, I cannot reproduce this. Did you perhaps navigate forward/backward in the browser or reload the install page when you recorded this, instead of starting install from scratch? The Works fine for me: Screen.Recording.2023-10-12.at.14.29.05.mov |
@swissspidy Hmm, I'm not sure now. Might be worth getting another tester to check it in case it's maybe something going on locally for me. |
@SergeyBiryukov @ocean90 Would appreciate your review on this one so we can fix it in 6.5 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well for me:
Screen.Recording.2023-11-16.at.14.41.59.mov
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Committed in https://core.trac.wordpress.org/changeset/57286 |
Works around issues with script localization happening too early because of blocks being registered.
Trac ticket: https://core.trac.wordpress.org/ticket/58696
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.