Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Footer Patterns: Followup Fixes #91

Closed
2 of 3 tasks
kjellr opened this issue Oct 12, 2021 · 1 comment · Fixed by #211
Closed
2 of 3 tasks

Footer Patterns: Followup Fixes #91

kjellr opened this issue Oct 12, 2021 · 1 comment · Fixed by #211
Labels
[Component] Block Patterns [Type] Bug Something isn't working [Type] Overview
Milestone
Beta 1

Comments

@kjellr
Copy link
Collaborator

kjellr commented Oct 12, 2021 •
edited
Loading

Following #85, there are a couple small things that we should try and readdress for the footer patterns:

Footer with query, title, and citation

  • Title and citation are oddly aligned on small screens. (Screenshot)

Footer with query, featured images, title, and citation

  • Title and citation are oddly aligned on small screens. (Screenshot)

Dark footer with title and citation

  • Title and citation have no left/right padding on small screens. (Screenshot)
@kjellr kjellr added this to the Beta 1 milestone Oct 12, 2021
This was referenced Nov 3, 2021
Merged
Merged
@carolinan
Copy link
Collaborator

carolinan commented Nov 3, 2021 •
edited
Loading

I did not find a great solution for the dark footer with title and citation. Adding padding to the sides and not only top and bottom would mean the texts don't align with the content.
One alternative would be to center the texts.

@kjellr kjellr mentioned this issue Nov 5, 2021
Merged
@jffng jffng closed this as completed in #211 Nov 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
[Component] Block Patterns [Type] Bug Something isn't working [Type] Overview
Projects
None yet
Milestone
Beta 1
Development

Successfully merging a pull request may close this issue.

Add more colorful header patterns, fix dark footer pattern WordPress/twentytwentytwo
2 participants
@kjellr @carolinan