Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: spacing styles for heading with annotation style in dust theme #636

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

add: spacing styles for heading with annotation style in dust theme #636

wants to merge 1 commit into from
+1 −0

Conversation

troychaplin
Copy link
Contributor

Description

Updated spacing as discussed in #605.

I set the bottom padding to 0.15rem instead of the originally suggested 0.2 based on a heading set in all caps still appearing to have more bottom space than the top.

Screenshots

test-2 test-1

@troychaplin troychaplin linked an issue Oct 26, 2024 that may be closed by this pull request
Dusk: Annotation vertical padding looks uneven #605
Open
@github-actions GitHub Actions
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@troychaplin troychaplin requested review from carolinan and juanfra and removed request for carolinan October 26, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfra juanfra Awaiting requested review from juanfra

@carolinan carolinan Awaiting requested review from carolinan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dusk: Annotation vertical padding looks uneven
1 participant
@troychaplin