Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: removed purple site title link color in dusk theme #610

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from
Open

update: removed purple site title link color in dusk theme #610

wants to merge 4 commits into from

Conversation

troychaplin
Copy link
Contributor

Description

This addresses #604. Removed paragraph link style that impacts site title and compared to other styles, which do not seem to have this link style in place. Some screenshots of how link in a para is treated with just an underline, no specific color treatment.

Screenshots

example-2 example-3 example-4 example-1

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 21, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: troychaplin <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: juanfra <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@carolinan
Copy link
Contributor

This change affects Dusk, but the screenshots are of the other variations.

In the design, the links are supposed to be purple, so this style should not be removed.
https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=77-338&node-type=frame&t=wE2ugqqAeMGWDKJ3-0

Does setting the correct color on styles > Blocks > core/site-title > elements > link not work?

@troychaplin
Copy link
Contributor Author

This change affects Dusk, but the screenshots are of the other variations.

In the design, the links are supposed to be purple, so this style should not be removed. https://www.figma.com/design/dzGCSntVch4EQdVERTqyVK/Twenty-Twenty-Five?node-id=77-338&node-type=frame&t=wE2ugqqAeMGWDKJ3-0

Does setting the correct color on styles > Blocks > core/site-title > elements > link not work?

Oh, then I’ll look at this again today

@juanfra
Copy link
Member

juanfra commented Oct 24, 2024

@troychaplin please let us know if you still have time to iterate on this. Thanks 🙏

@troychaplin
Copy link
Contributor Author

@troychaplin please let us know if you still have time to iterate on this. Thanks 🙏

Working on it. Can't figure it out, probably missing something easy here 😕

@carolinan
Copy link
Contributor

carolinan commented Oct 25, 2024 •
edited
Loading

The site title can't override the CSS that WP adds to the link color to the paragraph.

In Dusk, can you try removing the link color from the site title, and adding this directly under styles:
"css": "p.wp-block-site-title:not(.has-link-color) a { color: var(--wp--preset--color--accent-3);}",

That way it overrides the link style on the p element, and if the user adds a color in the block setting, that setting works.

@troychaplin
Copy link
Contributor Author

The site title can't override the CSS that WP adds to the link color to the paragraph.

In Dusk, can you try removing the link color from the site title, and adding this directly under styles: "css": "p.wp-block-site-title:not(.has-link-color) a { color: var(--wp--preset--color--accent-3);}",

That way it overrides the link style on the p element, and if the user adds a color in the block setting, that setting works.

Thank you! I’ll get back to this one shortly!

@juanfra
Copy link
Member

juanfra commented Oct 25, 2024

@carolinan another reason to try to get the class in the paragraph block 😅

@troychaplin
Copy link
Contributor Author

@carolinan thank you, this worked well and changes have been pushed

@troychaplin troychaplin linked an issue Oct 25, 2024 that may be closed by this pull request
Dusk: Site title is colored #604
Open
@troychaplin troychaplin changed the title update: removed para link style that impact site title update: removed purple site title link color in dusk theme Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dusk: Site title is colored
3 participants
@troychaplin @carolinan @juanfra