-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update: removed purple site title link color in dusk theme #610
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Preview changesYou can preview these changes by following the link below: I will update this comment with the latest preview links as you push more changes to this PR. Note The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions. |
This change affects Dusk, but the screenshots are of the other variations. In the design, the links are supposed to be purple, so this style should not be removed. Does setting the correct color on styles > Blocks > core/site-title > elements > link not work? |
Oh, then I’ll look at this again today |
@troychaplin please let us know if you still have time to iterate on this. Thanks 🙏 |
Working on it. Can't figure it out, probably missing something easy here 😕 |
The site title can't override the CSS that WP adds to the link color to the paragraph. In Dusk, can you try removing the link color from the site title, and adding this directly under styles: That way it overrides the link style on the p element, and if the user adds a color in the block setting, that setting works. |
Thank you! I’ll get back to this one shortly! |
@carolinan another reason to try to get the class in the paragraph block 😅 |
@carolinan thank you, this worked well and changes have been pushed |
Description
This addresses #604. Removed paragraph link style that impacts site title and compared to other styles, which do not seem to have this link style in place. Some screenshots of how link in a para is treated with just an underline, no specific color treatment.
Screenshots