Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Clean up posts patterns #411

Closed
richtabor opened this issue Sep 25, 2024 · 8 comments
Closed

Clean up posts patterns #411

richtabor opened this issue Sep 25, 2024 · 8 comments
Labels
[Component] Block Patterns [Type] Bug An existing feature does not function as intended.

Comments

@richtabor
Copy link
Member

Many of the posts patterns display quite poorly. What can we do to clean these up?

CleanShot 2024-09-25 at 15 00 08
CleanShot 2024-09-25 at 14 59 55

@richtabor richtabor added [Type] Bug An existing feature does not function as intended. [Component] Block Patterns labels Sep 25, 2024
@carolinan
Copy link
Contributor

Which patterns are these? I only see two that are part of the theme?

@carolinan
Copy link
Contributor

I suggest that this pattern, the query for the design with the right aligned posts, can be hidden. It is a simple query, and it may be confusing that it is called "right-aligned" when the posts are not right-aligned outside of its template.

posts-right-aligned

@richtabor
Copy link
Member Author

richtabor commented Sep 26, 2024

They're all present:

Portfolio Homepage
Photo blog posts
List of posts, 1 column
...

CleanShot 2024-09-26 at 11 57 18

@carolinan
Copy link
Contributor

Maybe hide all except for "more posts" ?

@carolinan
Copy link
Contributor

@beafialho @juanfra This issue needs more attention.

@juanfra juanfra added [Priority] High Used to indicate top priority items that need quick attention and removed [Priority] High Used to indicate top priority items that need quick attention labels Oct 9, 2024
@juanfra
Copy link
Member

juanfra commented Oct 9, 2024

I believe we can do the following:

  • Remove "Business homepage" from that list.
  • Remove "Shop homepage" from that list.
  • Improve the way the "Photo blog posts" is displayed there.

The first two do not list posts, so having them there doesn't make sense.

Screen.Recording.2024-10-09.at.11.45.51.mov

@juanfra
Copy link
Member

juanfra commented Oct 9, 2024

I just merged this PR. If we're good with this solution we should be good to close this issue.

@richtabor when you have time can you please check and see if there's anything else that you wanted to clean up here? Thanks 🙌

@juanfra
Copy link
Member

juanfra commented Oct 10, 2024

I'm closing this one as resolved via #532

Please feel free to re-open if you believe there's something else we should address.

@juanfra juanfra closed this as completed Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Component] Block Patterns [Type] Bug An existing feature does not function as intended.
Projects
None yet
Development

No branches or pull requests

3 participants