Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

No left and right margin for fully aligned columns #517

Closed
LittleBigThing opened this issue Nov 8, 2018 · 1 comment · Fixed by #591
Closed

No left and right margin for fully aligned columns #517

LittleBigThing opened this issue Nov 8, 2018 · 1 comment · Fixed by #591
Labels
bug Something isn't working

Comments

@LittleBigThing
Copy link

LittleBigThing commented Nov 8, 2018

We should add some margin (left and right) for fully aligned columns. It is fine not having margin for images, but text columns should have margins.

Example

Something like

.wp-block-columns {
		
	&.alignfull {
		margin-left: $size__spacing-unit;
		margin-right: $size__spacing-unit;
	}
}

in blocks.scss.

Only for the columns wrapper.

Or we might target first and last childs column blocks...

@kjellr kjellr added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Nov 8, 2018
@kjellr
Copy link
Collaborator

kjellr commented Nov 14, 2018

I'm going to change this to a bug, since it's unintentional that the alignfull variant of this block looks so different from the editor style. Adding some screenshots for reference here:

Editor:
screen shot 2018-11-14 at 9 38 58 am

Front End:
screen shot 2018-11-14 at 9 39 09 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants