Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT1 blocks: empty space between between header and footer #222

Closed
vindl opened this issue Feb 23, 2021 · 3 comments
Closed

TT1 blocks: empty space between between header and footer #222

vindl opened this issue Feb 23, 2021 · 3 comments

Comments

@vindl
Copy link
Member

vindl commented Feb 23, 2021

Currently we have margins around header and footer template parts in editing view of the Site Editor.

Screenshot 2021-02-23 at 14 36 16

Screenshot 2021-02-23 at 14 37 16

Would it make sense to remove them so as to align the header and footer with the beginning and ending of the page respectively?

cc @kjellr

@carolinan
Copy link
Collaborator

The theme does not add any extra top or bottom margins around template parts.
Do you mean the editor style that Gutenberg adds?

.block-editor-block-list__block {
    margin-top: 28px;
    margin-bottom: 28px;
}

Then that is not a theme issue, but an editor issue?

@vindl
Copy link
Member Author

vindl commented Feb 23, 2021

Then that is not a theme issue, but an editor issue?

Yep, that seems to be the case then. I'll carry this over to editor repo and close this issue. Thanks!

@creativecoder
Copy link

This can be closed, replaced by WordPress/gutenberg#29357

@kjellr kjellr closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants