Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TT1 Blocks: Cover Block: Migrate CSS to theme.json #116

Open
scruffian opened this issue Dec 9, 2020 · 1 comment
Open

TT1 Blocks: Cover Block: Migrate CSS to theme.json #116

scruffian opened this issue Dec 9, 2020 · 1 comment
Assignees
@MaggieCabrera

Comments

@scruffian
Copy link
Collaborator

The code is here.

From #82
@scruffian scruffian mentioned this issue Dec 9, 2020
Open
53 tasks
@MaggieCabrera MaggieCabrera self-assigned this Dec 10, 2020
@MaggieCabrera
Copy link
Collaborator

MaggieCabrera commented Dec 18, 2020 •
edited
Loading

After reviewing the code, the only changes that I think the cover block needs are dependant on this GB issue:

WordPress/gutenberg#27809

The rest of the CSS for this block is related to alignments. Some of it is unneeded and some of it I'm hesitant to add to the theme as it is since I expect the way alignments works to change when WordPress/gutenberg#26633 is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaggieCabrera MaggieCabrera

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scruffian @MaggieCabrera