The slug should be translatable

[davidperezgar]

Hey! Congratulations for the plugin! It's seems awesome!

I'm wondering that the slug will be better if it can be translated.

This is the line:
https://github.com/WordPress/slides/blob/master/register.php#L35

What do you think?

[ellatrix]

I think that makes sense. Is this usually done for custom post types? Do you have an example of another plugin doing this? I just want to be careful with breaking permalinks when you switch the language.

[davidperezgar]

Hello @ellatrix !
Yes, I give you the exact code:
array( 'slug' => _x('presentation', 'slug', 'slide')),

Only will change for the translations made in translate.wordpress.org. But I think, it's a better option because we will have translated urls ... 😉

[ellatrix]

Thanks. Could you link another plugin doing it this way?

[davidperezgar]

Yes, you can see it in this plugin:
https://plugins.trac.wordpress.org/browser/strong-testimonials/trunk/includes/post-types.php#L105

For example. (It has +80.000 installations)

[davidperezgar]

I've made a pull request 😉

[zengxiaoluan]

我翻译成了中文：https://translate.wordpress.org/projects/wp-plugins/slide/dev/zh-cn/default/