-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Trac contributors in SVN style props list. #30
Comments
Had a scenario come up today where a PR was opened to sync editor packages into Core SVN, but doing so would also fix a bug report on Trac. The ticket had lots of conversation before it was discovered the fix would need to be made upstream first. The sync commit needs to reference both tickets as fixed, and give props appropriately to reporters and testers on the other ticket. It would have been nice to say something like "@propsbot include Trac 12345" to include participants in the list on the pull request. |
In general I'm in favour but we need to consider that on some Trac tickets people leave a comment of little value just to get props. I usually filter those out when constructing the props list. |
@johnbillion Agreed. That's one reason why I've pushed back against any request that brings this tool into "fully automated" territory. Any contributor merging or committing code should always manually review the props list generated by @propsbot to ensure no one is left out or added despite not positively contributing. |
When a Trac URL is included in the PR description (as required in the handbook), the contributors on the ticket should be pulled in and added to the SVN-flavor list.
Each ticket has an RSS feed, so that can likely be used.
Because this will only apply to a
wordpress-develop
and maybe some meta repositories, enabling this with an input would probably be best.The text was updated successfully, but these errors were encountered: