Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization Detective should be automatically installed and activated when activating Embed Optimizer #1615

Closed
westonruter opened this issue Oct 21, 2024 · 0 comments · Fixed by #1644
Assignees
Labels
[Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@westonruter
Copy link
Member

The Embed Optimizer plugin works best Optimization Detective is also running. In fact, there are notices on the plugin list table to encourage users to also install Optimization Detective:

Image

However, when activating the Embed Optimizer plugin there is no advice or ability to install Optimization Detective:

Image

This being the case, when activating the Embed Optimizer plugin, we should automatically install Optimization Detective as a soft dependency.

When Optimization Detective is active alongside Embed Optimizer, the relationship between the two is already indicated in the plugin metadata for Optimization Detective:

Image

So users should be able to see why it was installed.

@westonruter westonruter added [Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature labels Oct 21, 2024
@westonruter westonruter added this to the performance-lab n.e.x.t milestone Oct 21, 2024
@github-project-automation github-project-automation bot moved this to Not Started/Backlog 📆 in WP Performance 2024 Oct 21, 2024
@westonruter westonruter moved this from Not Started/Backlog 📆 to To Do 🔧 in WP Performance 2024 Oct 21, 2024
@westonruter westonruter self-assigned this Nov 11, 2024
@westonruter westonruter changed the title Automatically install and activate Optimization Detective when activating Embed Optimizer Optimization Detective should be automatically installed and activated when activating Embed Optimizer Nov 11, 2024
@westonruter westonruter moved this from To Do 🔧 to Code Review 👀 in WP Performance 2024 Nov 11, 2024
@github-project-automation github-project-automation bot moved this from Code Review 👀 to Done 😃 in WP Performance 2024 Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Embed Optimizer Issues for the Embed Optimizer plugin (formerly Auto Sizes) [Plugin] Optimization Detective Issues for the Optimization Detective plugin [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
Status: Done 😃
1 participant