-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose WebP support under Site Health status tab #130
Comments
@felixarntz would it makes sense to add that information in a new tab in Site Health, instead of under "Status". Asking because it could be related to this issue: #97. And we might want to have every information output by the performance plugin in one single place. |
@JustinyAhin Potentially, yes. I think we shouldn't block this issue by discussion on the other though, so IMO we could start with showing this in the "Status" tab, and if/once we have a "Performance" tab, update it. |
@felixarntz If we end up working on this issue, I would like to work on it if you don't mind :) |
I like this idea of having something explicitly showing "WebP support", especially as part of making this the default sub size format. For the record, this is where we currently show WebP support, the simplified version might go there as well - under Site Health -> Info -> Media Handling. Maybe we should also show the sub-sized format(s) that WordPress will use? |
I do think this makes it pretty clear what formats are supported. |
I think this sort of message makes sense if WebP as default is enabled with the plugin. For the current situation, maybe limiting the message to "Uploading WebP (or whatever other support is missing) files is not supported" would be good? |
I have wrote this message keeping in mind that this plugin will eventually get merged into core, so instead of changing the message when we're planning to move it to core, I thought it's better to keep a message assuming WP will be using WebP images to boost performance. However, for the sake of more preciseness we can show current message when WebP module is activated, and something like "Uploading WebP files is not supported" when it's not. |
Since not every server environment supports translating JPEG uploads to WebP format, it's worth indicating this to site administrators in an easy-to-understand way. While we already have some basic PHP extension information about image capabilities in the Site Health info tab, it may be worth adding something explicitly about WebP in the Site Health "Status" tab.
For example a message like "WebP images are (not) supported by your server environment", with a brief description on why this is relevant. And potentially a note to "Ask your hosting provider to enable/update xyz"
Also see https://wordpress.slack.com/archives/C02KGN5K076/p1643112555307200?thread_ts=1643041077.295600&cid=C02KGN5K076
cc @adamsilverstein @getsource @spacedmonkey
The text was updated successfully, but these errors were encountered: