Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose WebP support under Site Health status tab #130

Closed
felixarntz opened this issue Jan 25, 2022 · 8 comments · Fixed by #141
Closed

Expose WebP support under Site Health status tab #130

felixarntz opened this issue Jan 25, 2022 · 8 comments · Fixed by #141
Assignees
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@felixarntz
Copy link
Member

felixarntz commented Jan 25, 2022

Since not every server environment supports translating JPEG uploads to WebP format, it's worth indicating this to site administrators in an easy-to-understand way. While we already have some basic PHP extension information about image capabilities in the Site Health info tab, it may be worth adding something explicitly about WebP in the Site Health "Status" tab.

For example a message like "WebP images are (not) supported by your server environment", with a brief description on why this is relevant. And potentially a note to "Ask your hosting provider to enable/update xyz"

Also see https://wordpress.slack.com/archives/C02KGN5K076/p1643112555307200?thread_ts=1643041077.295600&cid=C02KGN5K076

cc @adamsilverstein @getsource @spacedmonkey

@felixarntz felixarntz added [Type] Enhancement A suggestion for improvement of an existing feature [Focus] Images [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) Needs Discussion Anything that needs a discussion/agreement labels Jan 25, 2022
@JustinyAhin
Copy link
Member

JustinyAhin commented Jan 26, 2022

@felixarntz would it makes sense to add that information in a new tab in Site Health, instead of under "Status".

Asking because it could be related to this issue: #97. And we might want to have every information output by the performance plugin in one single place.

@felixarntz
Copy link
Member Author

@JustinyAhin Potentially, yes. I think we shouldn't block this issue by discussion on the other though, so IMO we could start with showing this in the "Status" tab, and if/once we have a "Performance" tab, update it.

@kirtangajjar
Copy link
Member

kirtangajjar commented Jan 27, 2022

@felixarntz If we end up working on this issue, I would like to work on it if you don't mind :)

@adamsilverstein
Copy link
Member

adamsilverstein commented Jan 27, 2022

I like this idea of having something explicitly showing "WebP support", especially as part of making this the default sub size format.

For the record, this is where we currently show WebP support, the simplified version might go there as well - under Site Health -> Info -> Media Handling. Maybe we should also show the sub-sized format(s) that WordPress will use?

image

@getsource
Copy link
Member

I do think this makes it pretty clear what formats are supported.
Maybe we could display a warning if any of the natively supported formats for resizing are not supported (or, the most common ones folks would notice problems with)?

@kirtangajjar
Copy link
Member

I was testing this out in my local and I have added this check in the status section for now. If the message sounds good, I can then raise a PR.

Screenshot from 2022-01-31 18-04-46

@getsource
Copy link
Member

I think this sort of message makes sense if WebP as default is enabled with the plugin.
Since if it's not, WebP is not used by WordPress to boost performance.

For the current situation, maybe limiting the message to "Uploading WebP (or whatever other support is missing) files is not supported" would be good?

@kirtangajjar
Copy link
Member

I have wrote this message keeping in mind that this plugin will eventually get merged into core, so instead of changing the message when we're planning to move it to core, I thought it's better to keep a message assuming WP will be using WebP images to boost performance.

However, for the sake of more preciseness we can show current message when WebP module is activated, and something like "Uploading WebP files is not supported" when it's not.

@eclarke1 eclarke1 added Needs Review and removed Needs Discussion Anything that needs a discussion/agreement labels Feb 8, 2022
@felixarntz felixarntz added [Module] WebP Support and removed [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) labels Mar 4, 2022
@swissspidy swissspidy added [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) and removed [Module] WebP Support labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants