Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Cards #179

Closed
schutzsmith opened this issue Jun 13, 2021 · 6 comments
Closed

Horizontal Cards #179

schutzsmith opened this issue Jun 13, 2021 · 6 comments

Comments

@schutzsmith
Copy link

schutzsmith commented Jun 13, 2021

Cards are a basic design system component common in most websites.

Pattern Title

Two column horizontal cards

Pattern Categories

Columns, Gallery

Screenshots

Screen Shot 2021-06-14 at 11 55 11 AM

Image Credits

CC0
https://search.creativecommons.org/photos/390c556e-48b2-44b5-8df6-20a2059202a9
https://search.creativecommons.org/photos/8b4970b4-8001-4212-aa6d-76295663334b

Block Markup

https://gist.github.com/schutzsmith/86abea462a4d682ff02571966a9ca3f6

@schutzsmith
Copy link
Author

Updated with more appropriate example text

@kjellr
Copy link
Collaborator

kjellr commented Jun 16, 2021

Hey there, thanks for this one.

Unfortunately we can't use the border included above, since that's a style that's specific to the Twenty Twenty-One theme for the moment. In terms of the rest of the pattern, I think it's ok, but it could use a little iteration in terms of the imagery and colors. The monochromatic look is interesting, but this might be a good opportunity to try a pattern that uses the new duotone effects in Gutenberg.

I also feel like this looks quite like a Query block pattern (especially with the little "Categories" above the titles) — so part of me wonders if this is something we should just wait on this one and implement it a Query block pattern later on.

@beafialho
Copy link
Collaborator

I agree with @kjellr, this would make a great query block pattern later on!

@melchoyce
Copy link
Collaborator

Will we be able to do any query block patterns before the directory launches? Wondering if we should close this one for now & revisit.

@ryelle
Copy link
Contributor

ryelle commented Jun 28, 2021

You could create Query Loop patterns, but there's no post content on the site, so the preview won't render anything on the frontend. If you want to make Query Loop patterns, you could create some posts on the site?

@melchoyce
Copy link
Collaborator

Cool. I think we're going to need to spend more time thinking about what kind of posts to create, and then maybe kick off a drive just to work on query block patterns. In the meantime, I'm going to close this issue, but let's please revisit it later!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants