From fd7a2956be0aae73c8f1ef4301e854fbc3a9588c Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Thu, 21 Dec 2023 23:43:12 +0000 Subject: [PATCH 01/24] - modified files to use slackapi for github workglow --- .github/workflows/discussion_ping.yml | 24 +++++++++----- .github/workflows/pr_ping.yml | 45 +++++++++++++++++++-------- 2 files changed, 49 insertions(+), 20 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 243eedec751..9c95e44fcda 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -18,10 +18,20 @@ jobs: discussion_author: ${{ github.event.discussion.user.login }} discussion_repo: ${{ github.event.repository.full_name }} steps: - - name: Send notification for new discussion - run: | - curl \ - "$slack_url" \ - -X POST \ - -H 'Content-Type: application/json' \ - -d '{"text":"New discussion opened by '"$discussion_author"' in '"$discussion_repo"': #'"$discussion_number"' - '"$discussion_title"'","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":github: New discussion opened by *'"$discussion_author"'* in `'"$discussion_repo"'`:\n<'"$discussion_url"'|#'"$discussion_number"' - '"$discussion_title"'>"}}]}' + - name: New discussion notification + id: slack + uses: slackapi/slack-github-action@1.23.0 + with: + payload: | + { + "text": "New discussion opened by '$discussionAuthor' in '$discussionRepo': #$discussionNumber - '$discussionTitle'", + "blocks": [ + { + "type": "section", + "text": { + "type": "mrkdwn", + "text": ":github: New discussion opened by *'$discussionAuthor'* in '`$discussionRepo`':\n<$discussionUrl|#$discussionNumber - '$discussionTitle'>" + } + } + ] + } \ No newline at end of file diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 41c8f1adfc6..433772f2b42 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -24,21 +24,40 @@ jobs: steps: - name: Send notification for new PR if: github.event.action == 'opened' + id: slack + uses: slackapi/slack-github-action@1.23.0 env: pr_status: ${{ github.event.pull_request.draft && ' draft ' || ' ' }} pr_icon: ${{ github.event.pull_request.draft && ':pr-draft:' || ':pull-request:' }} - run: | - curl \ - "$slack_url" \ - -X POST \ - -H 'Content-Type: application/json' \ - -d '{"text":"New'"$pr_status"'PR opened by '"$pr_author"' in '"$pr_repo"': #'"$pr_number"' - '"$pr_title"'","blocks":[{"type":"section","text":{"type":"mrkdwn","text":"'"$pr_icon"' New'"$pr_status"'PR opened by *'"$pr_author"'* in `'"$pr_repo"'`:\n<'"$pr_url"'|#'"$pr_number"' - '"$pr_title"'>"}}]}' - + with: + payload: | + { + "text": "New\"$pr_status\"PR opened by \"$pr_author\" in \"$pr_repo\": #\"$pr_number\" - \"$pr_title\"", + "blocks": [ + { + "type": "section", + "text": { + "type": "mrkdwn", + "text": "\"$pr_icon\" New\"$pr_status\"PR opened by *\"$pr_author\"* in `\"$pr_repo\"`:\n<\"$pr_url\"|#\"$pr_number\" - \"$pr_title\">" + } + } + ] + } - name: Send notification for PR marked ready if: github.event.action == 'ready_for_review' - run: | - curl \ - "$slack_url" \ - -X POST \ - -H 'Content-Type: application/json' \ - -d '{"text":"PR by '"$pr_author"' in '"$pr_repo"' marked ready for review: #'"$pr_number"' - '"$pr_title"'","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":pull-request: PR by *'"$pr_author"'* in `'"$pr_repo"'` marked ready for review:\n<'"$pr_url"'|#'"$pr_number"' - '"$pr_title"'>"}}]}' + id: slack + uses: slackapi/slack-github-action@1.23.0 + with: + payload: | + { + "text": "PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"", + "blocks": [ + { + "type": "section", + "text": { + "type": "mrkdwn", + "text": ":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>" + } + } + ] + } \ No newline at end of file From d1840286564466cdeced077e5575eb46643b0c75 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Thu, 21 Dec 2023 23:49:50 +0000 Subject: [PATCH 02/24] - added original for the step --- .github/workflows/discussion_ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 9c95e44fcda..0dd92ef0cff 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -18,7 +18,7 @@ jobs: discussion_author: ${{ github.event.discussion.user.login }} discussion_repo: ${{ github.event.repository.full_name }} steps: - - name: New discussion notification + - name: Send notification for new discussion id: slack uses: slackapi/slack-github-action@1.23.0 with: From 7df004ce1f7d8d7fae70362be57719dfc6a56c50 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sat, 23 Dec 2023 00:08:28 +0000 Subject: [PATCH 03/24] - removed curl and applied slackapi --- .github/workflows/pr_limit_reminders.yml | 19 ++++++++----------- 1 file changed, 8 insertions(+), 11 deletions(-) diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index fbb4084481c..4d439e67d8d 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -34,14 +34,11 @@ jobs: slack_id: ${{ needs.analyze-user-prs.outputs.slack_id }} steps: - name: Send notification - run: | - msg="Hi, Opener! \nYou currently have $pr_count Pull Request(s) open with requested reviews (totalling $((pr_count * 2)) required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" - - curl \ - "$slack_url" \ - -X POST \ - -H 'Content-Type: application/json' \ - -d '{ - "user": "'"$slack_id"'", - "message": "'"$msg"'" - }' + id: slack + uses: slackapi/slack-github-action@1.23.0 + with: + payload: | + { + "user": "'"$slack_id"'", + "message": "'"$msg"'" + } From e7eeafc7ef6367d834b35d733a04cf2874171fe5 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Fri, 22 Dec 2023 19:46:46 -0500 Subject: [PATCH 04/24] Update Slack notification ID in PR ping workflow --- .github/workflows/pr_ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 433772f2b42..441ab7e109e 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -45,7 +45,7 @@ jobs: } - name: Send notification for PR marked ready if: github.event.action == 'ready_for_review' - id: slack + id: slack-notifications uses: slackapi/slack-github-action@1.23.0 with: payload: | From f9f616a794dae0b5c9ab9d0dff612fcb70b8aec1 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Fri, 22 Dec 2023 19:56:07 -0500 Subject: [PATCH 05/24] Refactor GitHub Action payloads --- .github/workflows/discussion_ping.yml | 13 +------------ .github/workflows/pr_limit_reminders.yml | 5 +---- .github/workflows/pr_ping.yml | 13 +------------ 3 files changed, 3 insertions(+), 28 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 0dd92ef0cff..86008619e19 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -23,15 +23,4 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - { - "text": "New discussion opened by '$discussionAuthor' in '$discussionRepo': #$discussionNumber - '$discussionTitle'", - "blocks": [ - { - "type": "section", - "text": { - "type": "mrkdwn", - "text": ":github: New discussion opened by *'$discussionAuthor'* in '`$discussionRepo`':\n<$discussionUrl|#$discussionNumber - '$discussionTitle'>" - } - } - ] - } \ No newline at end of file + {"text": "New discussion opened by '$discussionAuthor' in '$discussionRepo': #$discussionNumber - '$discussionTitle'", "blocks": [{"type": "section", "text": {"type": "mrkdwn", "text": ":github: New discussion opened by *'$discussionAuthor'* in '`$discussionRepo`':\n<$discussionUrl|#$discussionNumber - '$discussionTitle'>"}}]} \ No newline at end of file diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 4d439e67d8d..d7074d689b4 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -38,7 +38,4 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - { - "user": "'"$slack_id"'", - "message": "'"$msg"'" - } + {"user": "'"$slack_id"'","message": "'"$msg"'"} \ No newline at end of file diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 441ab7e109e..3b0d3b33669 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -49,15 +49,4 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - { - "text": "PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"", - "blocks": [ - { - "type": "section", - "text": { - "type": "mrkdwn", - "text": ":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>" - } - } - ] - } \ No newline at end of file + {"text":"PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>"}}]} \ No newline at end of file From cfeacbb839fffe1caa021d4f3948984254624449 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Tue, 26 Dec 2023 15:17:01 +0300 Subject: [PATCH 06/24] Update .github/workflows/discussion_ping.yml --- .github/workflows/discussion_ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 86008619e19..d8a05523839 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -23,4 +23,4 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - {"text": "New discussion opened by '$discussionAuthor' in '$discussionRepo': #$discussionNumber - '$discussionTitle'", "blocks": [{"type": "section", "text": {"type": "mrkdwn", "text": ":github: New discussion opened by *'$discussionAuthor'* in '`$discussionRepo`':\n<$discussionUrl|#$discussionNumber - '$discussionTitle'>"}}]} \ No newline at end of file + {"text": "New discussion opened by '$discussionAuthor' in '$discussionRepo': #$discussionNumber - '$discussionTitle'", "blocks": [{"type": "section", "text": {"type": "mrkdwn", "text": ":github: New discussion opened by *'$discussionAuthor'* in '`$discussionRepo`':\n<$discussionUrl|#$discussionNumber - '$discussionTitle'>"}}]} From 7dfe9144d4b55c5f054f32ce9f6ee88aaaf03236 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Tue, 26 Dec 2023 15:17:05 +0300 Subject: [PATCH 07/24] Update .github/workflows/pr_limit_reminders.yml --- .github/workflows/pr_limit_reminders.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index d7074d689b4..557ba7e3db2 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -38,4 +38,4 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - {"user": "'"$slack_id"'","message": "'"$msg"'"} \ No newline at end of file + {"user": "'"$slack_id"'","message": "'"$msg"'"} From a494f6548c531054f4d1ee4573dd95d5e9db7653 Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Tue, 26 Dec 2023 15:17:10 +0300 Subject: [PATCH 08/24] Update .github/workflows/pr_ping.yml --- .github/workflows/pr_ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 3b0d3b33669..4cb171ef5fc 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -49,4 +49,4 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - {"text":"PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>"}}]} \ No newline at end of file + {"text":"PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>"}}]} From 2ec6ace07c4227c28cf616a08370918a52cebfe6 Mon Sep 17 00:00:00 2001 From: Dhruv Bhanushali Date: Tue, 26 Dec 2023 19:56:36 +0400 Subject: [PATCH 09/24] Remove trailing spaces to pass lint check --- .github/workflows/pr_ping.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 4cb171ef5fc..d273fb819e3 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -30,7 +30,7 @@ jobs: pr_status: ${{ github.event.pull_request.draft && ' draft ' || ' ' }} pr_icon: ${{ github.event.pull_request.draft && ':pr-draft:' || ':pull-request:' }} with: - payload: | + payload: | { "text": "New\"$pr_status\"PR opened by \"$pr_author\" in \"$pr_repo\": #\"$pr_number\" - \"$pr_title\"", "blocks": [ @@ -47,6 +47,6 @@ jobs: if: github.event.action == 'ready_for_review' id: slack-notifications uses: slackapi/slack-github-action@1.23.0 - with: + with: payload: | {"text":"PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>"}}]} From 7c71dda10b946a09e8a477efa53cc96cde5b943f Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sat, 30 Dec 2023 18:46:34 -0500 Subject: [PATCH 10/24] fixed the vatiables discussion_ping.yml --- .github/workflows/discussion_ping.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index d8a05523839..d56a082bdfa 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -23,4 +23,14 @@ jobs: uses: slackapi/slack-github-action@1.23.0 with: payload: | - {"text": "New discussion opened by '$discussionAuthor' in '$discussionRepo': #$discussionNumber - '$discussionTitle'", "blocks": [{"type": "section", "text": {"type": "mrkdwn", "text": ":github: New discussion opened by *'$discussionAuthor'* in '`$discussionRepo`':\n<$discussionUrl|#$discussionNumber - '$discussionTitle'>"}}]} + { + "text": "New discussion opened by '${{discussionAuthor}}' in '${{discussionRepo}}': #${{discussionNumber}} - '${{discussionTitle}}'", + "blocks": [ + { + "type": "section", + "text": { + "type": "mrkdwn", + "text": ":github: New discussion opened by *'${{discussionAuthor}}'* in '`${{discussionRepo}}`':\n<${{discussionUrl}}|#${{discussionNumber}} - '${{discussionTitle}}'>" + } + } + ]} From ad3b37eba1962b66bbd3979055c9ba5fdd15acfc Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sat, 30 Dec 2023 18:50:35 -0500 Subject: [PATCH 11/24] added variables and fixed the slack action api version for discussion_ping.yml --- .github/workflows/discussion_ping.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index d56a082bdfa..78358fc53a1 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -17,10 +17,12 @@ jobs: discussion_title: ${{ github.event.discussion.title }} discussion_author: ${{ github.event.discussion.user.login }} discussion_repo: ${{ github.event.repository.full_name }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK steps: - name: Send notification for new discussion id: slack - uses: slackapi/slack-github-action@1.23.0 + uses: slackapi/slack-github-action@1.24.0 with: payload: | { From d04fc985b0accad1049bb32308541c71c0de34e9 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sat, 30 Dec 2023 18:58:03 -0500 Subject: [PATCH 12/24] added variables and fixed the slack action api version for pr_ping.yml --- .github/workflows/pr_ping.yml | 23 ++++++++++++++++++----- 1 file changed, 18 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index d273fb819e3..96a1974495e 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -21,24 +21,26 @@ jobs: pr_title: ${{ github.event.pull_request.title }} pr_author: ${{ github.event.pull_request.user.login }} pr_repo: ${{ github.event.pull_request.base.repo.full_name }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK steps: - name: Send notification for new PR if: github.event.action == 'opened' id: slack - uses: slackapi/slack-github-action@1.23.0 + uses: slackapi/slack-github-action@1.24.0 env: pr_status: ${{ github.event.pull_request.draft && ' draft ' || ' ' }} pr_icon: ${{ github.event.pull_request.draft && ':pr-draft:' || ':pull-request:' }} with: payload: | { - "text": "New\"$pr_status\"PR opened by \"$pr_author\" in \"$pr_repo\": #\"$pr_number\" - \"$pr_title\"", + "text": "New\"${{pr_status}}\"PR opened by \"${{pr_author}}\" in \"${{pr_repo}}\": #\"${{pr_number}}\" - \"${{pr_title}}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": "\"$pr_icon\" New\"$pr_status\"PR opened by *\"$pr_author\"* in `\"$pr_repo\"`:\n<\"$pr_url\"|#\"$pr_number\" - \"$pr_title\">" + "text": "\"${{pr_icon}}\" New\"${{pr_status}}\"PR opened by *\"${{pr_author}}\"* in `\"${{pr_repo}}\"`:\n<\"$pr_url\"|#\"${{pr_number}}\" - \"${{pr_title}}\">" } } ] @@ -46,7 +48,18 @@ jobs: - name: Send notification for PR marked ready if: github.event.action == 'ready_for_review' id: slack-notifications - uses: slackapi/slack-github-action@1.23.0 + uses: slackapi/slack-github-action@1.24.0 with: payload: | - {"text":"PR by \"$pr_author\" in \"$pr_repo\" marked ready for review: #$pr_number - \"$pr_title\"","blocks":[{"type":"section","text":{"type":"mrkdwn","text":":pull-request: PR by *$pr_author* in `$pr_repo` marked ready for review:\n<$pr_url|#$pr_number - $pr_title>"}}]} + { + "text": "PR by \"${{pr_author}}\" in \"${{pr_repo}}\" marked ready for review: #${{pr_number}} - \"${{pr_title}}\"", + "blocks": [ + { + "type": "section", + "text": { + "type": "mrkdwn", + "text": ":pull-request: PR by *${{pr_author}}* in `${{pr_repo}}` marked ready for review:\n<$pr_url|#${{pr_number}} - ${{pr_title}}>" + } + } + ] + } From 49dbd72558aa4c832ac8412072485b9f35606d32 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sat, 30 Dec 2023 19:06:01 -0500 Subject: [PATCH 13/24] added variables and fixed the slack action api version for pr_limit_reminder.yml --- .github/workflows/pr_limit_reminders.yml | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 557ba7e3db2..64429670fdf 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -32,10 +32,15 @@ jobs: slack_url: ${{ secrets.SLACK_DM_WEBHOOK_URL }} pr_count: ${{ needs.analyze-user-prs.outputs.pr_count }} slack_id: ${{ needs.analyze-user-prs.outputs.slack_id }} + SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} + SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK steps: - name: Send notification id: slack - uses: slackapi/slack-github-action@1.23.0 + uses: slackapi/slack-github-action@1.24.0 with: payload: | - {"user": "'"$slack_id"'","message": "'"$msg"'"} + { + "user": "${{env.slack_id}}", + "message": "Hi, Opener! \nYou currently have ${{env.pr_count}} Pull Request(s) open with requested reviews (totalling ${{((env.pr_count * 2))}} required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" + } From bec2a53e48850d4049749920377c9362a7dc4e0a Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 02:53:27 +0000 Subject: [PATCH 14/24] Update discussion ping message variables --- .github/workflows/discussion_ping.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 78358fc53a1..64e9a998049 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -26,13 +26,13 @@ jobs: with: payload: | { - "text": "New discussion opened by '${{discussionAuthor}}' in '${{discussionRepo}}': #${{discussionNumber}} - '${{discussionTitle}}'", + "text": "New discussion opened by '${{env.discussionAuthor}}' in '${{env.discussionRepo}}': #${{env.discussionNumber}} - '${{env.discussionTitle}}'", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":github: New discussion opened by *'${{discussionAuthor}}'* in '`${{discussionRepo}}`':\n<${{discussionUrl}}|#${{discussionNumber}} - '${{discussionTitle}}'>" + "text": ":github: New discussion opened by *'${{env.discussionAuthor}}'* in '`${{env.discussionRepo}}`':\n<${{env.discussionUrl}}|#${{env.discussionNumber}} - '${{env.discussionTitle}}'>" } } ]} From 62fd6c3144ecc33586ac002d7924ee2833ee00ee Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 02:59:08 +0000 Subject: [PATCH 15/24] Update Slack message format in PR limit reminders and PR ping workflows --- .github/workflows/pr_limit_reminders.yml | 2 +- .github/workflows/pr_ping.yml | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 64429670fdf..0a5cf3777d2 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -42,5 +42,5 @@ jobs: payload: | { "user": "${{env.slack_id}}", - "message": "Hi, Opener! \nYou currently have ${{env.pr_count}} Pull Request(s) open with requested reviews (totalling ${{((env.pr_count * 2))}} required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" + "message": "Hi, Opener! \nYou currently have ${{env.pr_count}} Pull Request(s) open with requested reviews (totalling ${{mul(env.pr_count, 2)}} required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" } diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 96a1974495e..8762126a2fd 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -34,13 +34,13 @@ jobs: with: payload: | { - "text": "New\"${{pr_status}}\"PR opened by \"${{pr_author}}\" in \"${{pr_repo}}\": #\"${{pr_number}}\" - \"${{pr_title}}\"", + "text": "New\"${{env.pr_status}}\"PR opened by \"${{env.pr_author}}\" in \"${{env.pr_repo}}\": #\"${{env.pr_number}}\" - \"${{env.pr_title}}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": "\"${{pr_icon}}\" New\"${{pr_status}}\"PR opened by *\"${{pr_author}}\"* in `\"${{pr_repo}}\"`:\n<\"$pr_url\"|#\"${{pr_number}}\" - \"${{pr_title}}\">" + "text": "\"${{env.pr_icon}}\" New\"${{env.pr_status}}\"PR opened by *\"${{env.pr_author}}\"* in `\"${{env.pr_repo}}\"`:\n<\"$pr_url\"|#\"${{env.pr_number}}\" - \"${{env.pr_title}}\">" } } ] @@ -52,13 +52,13 @@ jobs: with: payload: | { - "text": "PR by \"${{pr_author}}\" in \"${{pr_repo}}\" marked ready for review: #${{pr_number}} - \"${{pr_title}}\"", + "text": "PR by \"${{env.pr_author}}\" in \"${{env.pr_repo}}\" marked ready for review: #${{env.pr_number}} - \"${{env.pr_title}}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":pull-request: PR by *${{pr_author}}* in `${{pr_repo}}` marked ready for review:\n<$pr_url|#${{pr_number}} - ${{pr_title}}>" + "text": ":pull-request: PR by *${{env.pr_author}}* in `${{env.pr_repo}}` marked ready for review:\n<$pr_url|#${{env.pr_number}} - ${{env.pr_title}}>" } } ] From 190f1e2b608c452f7a5c6598a3233855e8870d82 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 03:03:58 +0000 Subject: [PATCH 16/24] Fix multiplication syntax in Slack message --- .github/workflows/pr_limit_reminders.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 0a5cf3777d2..2b37b98cd5c 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -42,5 +42,5 @@ jobs: payload: | { "user": "${{env.slack_id}}", - "message": "Hi, Opener! \nYou currently have ${{env.pr_count}} Pull Request(s) open with requested reviews (totalling ${{mul(env.pr_count, 2)}} required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" + "message": "Hi, Opener! \nYou currently have ${{env.pr_count}} Pull Request(s) open with requested reviews (totalling $((${{env.pr_count}} * 2)) required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" } From 793a6ca8905bebc25141754cffdbfb3fa51fd7e0 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 03:06:52 +0000 Subject: [PATCH 17/24] Fix formatting in discussion_ping.yml --- .github/workflows/discussion_ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 64e9a998049..3af1494ac42 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -35,4 +35,4 @@ jobs: "text": ":github: New discussion opened by *'${{env.discussionAuthor}}'* in '`${{env.discussionRepo}}`':\n<${{env.discussionUrl}}|#${{env.discussionNumber}} - '${{env.discussionTitle}}'>" } } - ]} + ]} \ No newline at end of file From bcaae46d9e5d7e8c5186a0d140a79cf71fee8a65 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 03:11:45 +0000 Subject: [PATCH 18/24] Update discussion_ping.yml to include additional notification message --- .github/workflows/discussion_ping.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 3af1494ac42..0279b2541bd 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -35,4 +35,6 @@ jobs: "text": ":github: New discussion opened by *'${{env.discussionAuthor}}'* in '`${{env.discussionRepo}}`':\n<${{env.discussionUrl}}|#${{env.discussionNumber}} - '${{env.discussionTitle}}'>" } } - ]} \ No newline at end of file + ] + } + \ No newline at end of file From 174e5168eed06d2a614a786f33f1d99ca37cc73e Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 03:13:44 +0000 Subject: [PATCH 19/24] Fixing linting issue --- .github/workflows/discussion_ping.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 0279b2541bd..db2b3a66689 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -37,4 +37,4 @@ jobs: } ] } - \ No newline at end of file + \ No newline at end of file From 38de286759808cb9e7af635ff5a7f8aa65fb73e2 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 20:55:31 +0000 Subject: [PATCH 20/24] Update discussion ping message format --- .github/workflows/discussion_ping.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index db2b3a66689..454146c8f30 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -26,7 +26,7 @@ jobs: with: payload: | { - "text": "New discussion opened by '${{env.discussionAuthor}}' in '${{env.discussionRepo}}': #${{env.discussionNumber}} - '${{env.discussionTitle}}'", + "text": "New discussion opened by '${{env.discussionAuthor}}' in '${{env.discussionRepo}}': #${{env.discussionNumber}} - '${{env.discussionTitle}}'", "blocks": [ { "type": "section", @@ -37,4 +37,3 @@ jobs: } ] } - \ No newline at end of file From 3db92211271895b1def86f083c3846e7de692238 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Sun, 31 Dec 2023 21:05:33 +0000 Subject: [PATCH 21/24] Update variable names in GitHub workflow files --- .github/workflows/discussion_ping.yml | 4 ++-- .github/workflows/pr_ping.yml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index 454146c8f30..e9ca9bf3ebf 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -26,13 +26,13 @@ jobs: with: payload: | { - "text": "New discussion opened by '${{env.discussionAuthor}}' in '${{env.discussionRepo}}': #${{env.discussionNumber}} - '${{env.discussionTitle}}'", + "text": "New discussion opened by ${{env.discussion_author}} in ${{env.discussion_repo}}: #${{env.discussion_number}} - ${{env.discussion_title}}", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":github: New discussion opened by *'${{env.discussionAuthor}}'* in '`${{env.discussionRepo}}`':\n<${{env.discussionUrl}}|#${{env.discussionNumber}} - '${{env.discussionTitle}}'>" + "text": ":github: New discussion opened by *${{env.discussion_author}}* in ${{env.discussion_repo}}:\n<${{env.discussion_url}}|#${{env.discussion_number}} - ${{env.discussion_title}}>" } } ] diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 8762126a2fd..1ff4971ced4 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -34,7 +34,7 @@ jobs: with: payload: | { - "text": "New\"${{env.pr_status}}\"PR opened by \"${{env.pr_author}}\" in \"${{env.pr_repo}}\": #\"${{env.pr_number}}\" - \"${{env.pr_title}}\"", + "text": "New \"${{env.pr_status}}\" PR opened by \"${{env.pr_author}}\" in \"${{env.pr_repo}}\": #\"${{env.pr_number}}\" - \"${{env.pr_title}}\"", "blocks": [ { "type": "section", From 704da9e0829b71ade822037bb36683be0faa9f00 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Tue, 2 Jan 2024 22:49:31 +0000 Subject: [PATCH 22/24] Update variable names in GitHub workflows --- .github/workflows/discussion_ping.yml | 4 ++-- .github/workflows/pr_limit_reminders.yml | 4 ++-- .github/workflows/pr_ping.yml | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index e9ca9bf3ebf..b085b78aba9 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -26,13 +26,13 @@ jobs: with: payload: | { - "text": "New discussion opened by ${{env.discussion_author}} in ${{env.discussion_repo}}: #${{env.discussion_number}} - ${{env.discussion_title}}", + "text": "New discussion opened by ${{ discussion_author }} in ${{ discussion_repo }}: #${{ discussion_number }} - ${{ discussion_title }}", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":github: New discussion opened by *${{env.discussion_author}}* in ${{env.discussion_repo}}:\n<${{env.discussion_url}}|#${{env.discussion_number}} - ${{env.discussion_title}}>" + "text": ":github: New discussion opened by *${{ discussion_author }}* in ${{ discussion_repo }}:\n<${{ discussion_url }}|#${{ discussion_number }} - ${{ discussion_title }}>" } } ] diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 2b37b98cd5c..5a898164c0f 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -41,6 +41,6 @@ jobs: with: payload: | { - "user": "${{env.slack_id}}", - "message": "Hi, Opener! \nYou currently have ${{env.pr_count}} Pull Request(s) open with requested reviews (totalling $((${{env.pr_count}} * 2)) required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" + "user": "${{ slack_id }}", + "message": "Hi, Opener! \nYou currently have ${{ pr_count }} Pull Request(s) open with requested reviews (totalling $((${{ pr_count }} * 2)) required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" } diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 1ff4971ced4..ee9a7e83017 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -34,13 +34,13 @@ jobs: with: payload: | { - "text": "New \"${{env.pr_status}}\" PR opened by \"${{env.pr_author}}\" in \"${{env.pr_repo}}\": #\"${{env.pr_number}}\" - \"${{env.pr_title}}\"", + "text": "New \"${{ pr_status }}\" PR opened by \"${{ pr_author }}\" in \"${{ pr_repo }}\": #\"${{ pr_number }}\" - \"${{ pr_title }}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": "\"${{env.pr_icon}}\" New\"${{env.pr_status}}\"PR opened by *\"${{env.pr_author}}\"* in `\"${{env.pr_repo}}\"`:\n<\"$pr_url\"|#\"${{env.pr_number}}\" - \"${{env.pr_title}}\">" + "text": "\"${{ pr_icon }}\" New\"${{ pr_status }}\"PR opened by *\"${{ pr_author }}\"* in `\"${{ pr_repo }}\"`:\n<\"${{ pr_url }}\"|#\"${{ pr_number }}\" - \"${{ pr_title }}\">" } } ] @@ -52,13 +52,13 @@ jobs: with: payload: | { - "text": "PR by \"${{env.pr_author}}\" in \"${{env.pr_repo}}\" marked ready for review: #${{env.pr_number}} - \"${{env.pr_title}}\"", + "text": "PR by \"${{ pr_author }}\" in \"${{ pr_repo }}\" marked ready for review: #${{ pr_number }} - \"${{ pr_title }}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":pull-request: PR by *${{env.pr_author}}* in `${{env.pr_repo}}` marked ready for review:\n<$pr_url|#${{env.pr_number}} - ${{env.pr_title}}>" + "text": ":pull-request: PR by *${{ pr_author }}* in `${{ pr_repo }}` marked ready for review:\n<${{ pr_url }}|#${{ pr_number }} - ${{ pr_title }}>" } } ] From 0cb727abdcc9c1c072c1f787cc15782fcc7130df Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Tue, 2 Jan 2024 23:04:54 +0000 Subject: [PATCH 23/24] Fixed the variable Names added env. as Prefix --- .github/workflows/discussion_ping.yml | 4 ++-- .github/workflows/pr_limit_reminders.yml | 4 ++-- .github/workflows/pr_ping.yml | 8 ++++---- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index b085b78aba9..f67a40d3c8f 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -26,13 +26,13 @@ jobs: with: payload: | { - "text": "New discussion opened by ${{ discussion_author }} in ${{ discussion_repo }}: #${{ discussion_number }} - ${{ discussion_title }}", + "text": "New discussion opened by ${{ env.discussion_author }} in ${{ env.discussion_repo }}: #${{ env.discussion_number }} - ${{ env.discussion_title }}", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":github: New discussion opened by *${{ discussion_author }}* in ${{ discussion_repo }}:\n<${{ discussion_url }}|#${{ discussion_number }} - ${{ discussion_title }}>" + "text": ":github: New discussion opened by *${{ env.discussion_author }}* in ${{ env.discussion_repo }}:\n<${{ env.discussion_url }}|#${{ env.discussion_number }} - ${{ env.discussion_title }}>" } } ] diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 5a898164c0f..59928949ce4 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -41,6 +41,6 @@ jobs: with: payload: | { - "user": "${{ slack_id }}", - "message": "Hi, Opener! \nYou currently have ${{ pr_count }} Pull Request(s) open with requested reviews (totalling $((${{ pr_count }} * 2)) required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" + "user": "${{ env.slack_id }}", + "message": "Hi, Opener! \nYou currently have ${{ env.pr_count }} Pull Request(s) open with requested reviews (totalling $((${{ env.pr_count }} * 2)) required reviews). \nTo help ease the review burden, increase review velocity for older PRs, and improve the equitable distribution of project maintenance tasks across the team, please consider reviewing this list of ways to contribute instead of working on new code contributions: \nhttps://docs.openverse.org/meta/maintainer_tasks.html" } diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index ee9a7e83017..56655530e10 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -34,13 +34,13 @@ jobs: with: payload: | { - "text": "New \"${{ pr_status }}\" PR opened by \"${{ pr_author }}\" in \"${{ pr_repo }}\": #\"${{ pr_number }}\" - \"${{ pr_title }}\"", + "text": "New \"${{ env.pr_status }}\" PR opened by \"${{ env.pr_author }}\" in \"${{ env.pr_repo }}\": #\"${{ env.pr_number }}\" - \"${{ env.pr_title }}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": "\"${{ pr_icon }}\" New\"${{ pr_status }}\"PR opened by *\"${{ pr_author }}\"* in `\"${{ pr_repo }}\"`:\n<\"${{ pr_url }}\"|#\"${{ pr_number }}\" - \"${{ pr_title }}\">" + "text": "\"${{ env.pr_icon }}\" New\"${{ env.pr_status }}\"PR opened by *\"${{ env.pr_author }}\"* in `\"${{ env.pr_repo }}\"`:\n<\"${{ env.pr_url }}\"|#\"${{ env.pr_number }}\" - \"${{ env.pr_title }}\">" } } ] @@ -52,13 +52,13 @@ jobs: with: payload: | { - "text": "PR by \"${{ pr_author }}\" in \"${{ pr_repo }}\" marked ready for review: #${{ pr_number }} - \"${{ pr_title }}\"", + "text": "PR by \"${{ env.pr_author }}\" in \"${{ env.pr_repo }}\" marked ready for review: #${{ env.pr_number }} - \"${{ env.pr_title }}\"", "blocks": [ { "type": "section", "text": { "type": "mrkdwn", - "text": ":pull-request: PR by *${{ pr_author }}* in `${{ pr_repo }}` marked ready for review:\n<${{ pr_url }}|#${{ pr_number }} - ${{ pr_title }}>" + "text": ":pull-request: PR by *${{ env.pr_author }}* in `${{ env.pr_repo }}` marked ready for review:\n<${{ env.pr_url }}|#${{ env.pr_number }} - ${{ env.pr_title }}>" } } ] From 81ac6d79b41427731b1d8d55d6416938e1ec1517 Mon Sep 17 00:00:00 2001 From: Pk Patel Date: Mon, 8 Jan 2024 21:23:35 +0000 Subject: [PATCH 24/24] - removed the unused env variables --- .github/workflows/discussion_ping.yml | 1 - .github/workflows/pr_limit_reminders.yml | 1 - .github/workflows/pr_ping.yml | 1 - 3 files changed, 3 deletions(-) diff --git a/.github/workflows/discussion_ping.yml b/.github/workflows/discussion_ping.yml index f67a40d3c8f..7a4ef5af902 100644 --- a/.github/workflows/discussion_ping.yml +++ b/.github/workflows/discussion_ping.yml @@ -11,7 +11,6 @@ jobs: name: Send Slack message runs-on: ubuntu-latest env: - slack_url: ${{ secrets.SLACK_WEBHOOK_URL }} discussion_url: ${{ github.event.discussion.html_url }} discussion_number: ${{ github.event.discussion.number }} discussion_title: ${{ github.event.discussion.title }} diff --git a/.github/workflows/pr_limit_reminders.yml b/.github/workflows/pr_limit_reminders.yml index 59928949ce4..6e67dfacf32 100644 --- a/.github/workflows/pr_limit_reminders.yml +++ b/.github/workflows/pr_limit_reminders.yml @@ -29,7 +29,6 @@ jobs: if: ${{ needs.analyze-user-prs.outputs.pr_count >= 3 }} runs-on: ubuntu-latest env: - slack_url: ${{ secrets.SLACK_DM_WEBHOOK_URL }} pr_count: ${{ needs.analyze-user-prs.outputs.pr_count }} slack_id: ${{ needs.analyze-user-prs.outputs.slack_id }} SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} diff --git a/.github/workflows/pr_ping.yml b/.github/workflows/pr_ping.yml index 56655530e10..1537b458fd0 100644 --- a/.github/workflows/pr_ping.yml +++ b/.github/workflows/pr_ping.yml @@ -15,7 +15,6 @@ jobs: !startsWith(github.event.pull_request.title, '🔄') runs-on: ubuntu-latest env: - slack_url: ${{ secrets.SLACK_WEBHOOK_URL }} pr_url: ${{ github.event.pull_request.html_url }} pr_number: ${{ github.event.pull_request.number }} pr_title: ${{ github.event.pull_request.title }}