Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the code for computing filetype (extension) #702

Open
obulat opened this issue May 20, 2022 · 0 comments
Open

Remove the code for computing filetype (extension) #702

obulat opened this issue May 20, 2022 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: ingestion server Related to the ingestion/data refresh server ⛔ status: blocked Blocked & therefore, not ready for work
Milestone
Data normalizatio...

Comments

@obulat
Copy link
Contributor

obulat commented May 20, 2022 •
edited
Loading

Blocked by #1560

Problem

We are currently using code to compute extension (filetype) for some images that do not have it in the database. This code should become unnecessary when we normalize data in the database.

Description

We should remove the code that computes the extension during ES indexing as it should be available in the filetype field for all media items in the database.
https://github.com/WordPress/openverse-api/blob/2e85caf7aede8aaf9d77cd5cb050f50b860ee58e/ingestion_server/ingestion_server/elasticsearch_models.py#L135-L144
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users ⛔ status: blocked Blocked & therefore, not ready for work data normalization labels May 20, 2022
@obulat obulat mentioned this issue May 20, 2022
Open
29 tasks
@obulat obulat added ✨ goal: improvement Improvement to an existing user-facing feature and removed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels May 20, 2022
@obulat obulat transferred this issue from WordPress/openverse-api Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat obulat moved this from 📋 Backlog to ⛔ Blocked in Openverse Backlog Feb 24, 2023
@obulat obulat added 🧱 stack: ingestion server Related to the ingestion/data refresh server and removed 🧱 stack: backend labels Mar 20, 2023
@dhruvkb dhruvkb added this to the Data normalization milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: ingestion server Related to the ingestion/data refresh server ⛔ status: blocked Blocked & therefore, not ready for work
Projects
Openverse Backlog
Status: ⛔ Blocked
Openverse Data Normalization
Status: Todo
Milestone
Data normalization II
Development

No branches or pull requests
2 participants
@obulat @dhruvkb