Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make license_url a non-optional media property #552

Open
1 task
obulat opened this issue May 20, 2022 · 0 comments
Open
1 task

Make license_url a non-optional media property #552

obulat opened this issue May 20, 2022 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Milestone
Data normalizatio...

Comments

@obulat
Copy link
Contributor

obulat commented May 20, 2022 •
edited
Loading

Blocked by the work in the Catalog and API.

Problem

Currently, we set the license_url as an optional property for media, but it should be available for all media items.

Description

After normalizing the data in the catalog/API, we should set it as required.
https://github.com/WordPress/openverse-frontend/blob/fd2c7fba20b48535981dcd1167ce0ea3799fb36a/src/models/media.ts#L24

openverse/frontend/src/types/media.ts

Line 30 in 8ee33a6

license_url?: string

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users ⛔ status: blocked Blocked & therefore, not ready for work data normalization labels May 20, 2022
@obulat obulat mentioned this issue May 20, 2022
Open
29 tasks
@obulat obulat added ✨ goal: improvement Improvement to an existing user-facing feature and removed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels May 20, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat obulat moved this from 📋 Backlog to ⛔ Blocked in Openverse Backlog Feb 24, 2023
@dhruvkb dhruvkb added this to the Data normalization milestone Dec 2, 2023
@obulat obulat mentioned this issue Mar 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend ⛔ status: blocked Blocked & therefore, not ready for work
Projects
Openverse Backlog
Status: ⛔ Blocked
Milestone
Data normalization II
Development

No branches or pull requests
2 participants
@obulat @dhruvkb