Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language selector hard to read in dark mode #5277

Closed
dhruvkb opened this issue Dec 15, 2024 · 1 comment · Fixed by #5278
Closed

Language selector hard to read in dark mode #5277

dhruvkb opened this issue Dec 15, 2024 · 1 comment · Fixed by #5278
Assignees
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Dec 15, 2024

Description

When the theme is set to dark, the language selector options are hard to read. This is because the options are rendered in a light font on a white surface.

Screenshots

Image

Environment

  • Device: desktop
  • OS: Windows 11
  • Browser: Chrome 131.0.6778.140

Additional context

This was reported on Slack.

@dhruvkb dhruvkb added ♿️ aspect: a11y Concerns related to the project's accessibility 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend labels Dec 15, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Dec 15, 2024
@dhruvkb
Copy link
Member Author

dhruvkb commented Dec 15, 2024

Okay, this was really bothering me because the select field dropdown is supposed to be a component rendered by the operating system so it should definitely have nothing to do with the color scheme of the website.

So I looked into this using BrowserStack and it turns out that on Windows (crucially different from the behaviour of macOS) the text color and background color of the <select> dropdown is actually determined from the individual <option> elements and can even be different for different options!

Image

@dhruvkb dhruvkb self-assigned this Dec 15, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Dec 15, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Dec 15, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

1 participant