Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Newest version of vite in Playwright container causes the build to fail #5197

Closed
obulat opened this issue Nov 28, 2024 · 0 comments · Fixed by #5198
Closed

Newest version of vite in Playwright container causes the build to fail #5197

obulat opened this issue Nov 28, 2024 · 0 comments · Fixed by #5198
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Nov 28, 2024

Description

Playwright container installs the latest version of Vite (6.0.1) which is incompatible with some of our dependencies. This causes failed builds in the CI Playwright tests.

Reproduction

See error in this CI run: https://github.com/WordPress/openverse/actions/runs/12063941806/job/33640021131

Additional context

I don't know why Playwright started loading v6.0.1 of vite now, but we should probably start, too :)
Priority set to critical because the CI is failing
@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend labels Nov 28, 2024
@openverse-bot openverse-bot moved this to 📅 To Do in Openverse Backlog Nov 28, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 📋 Backlog in Openverse Backlog Nov 28, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Nov 28, 2024
@obulat obulat mentioned this issue Nov 28, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Nov 28, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the CI by fixing the i18n dependencies, and updating vite to v6.0.1 WordPress/openverse
1 participant
@obulat