Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Nuxt unit-tests that were marked as skipped during the Nuxt 3 migration #5171

Open
obulat opened this issue Nov 18, 2024 · 0 comments
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Nov 18, 2024

Problem

Some of the unit tests could not be fixed during the Nuxt 3 migration, so they were marked with skip and don't run now.

Description

The skipped tests are marked with .skip modifier, and also [will] have this issue as a comment above them.

Alternatives

We could remove/replace the tests that are no longer relevant.

Additional context

The tests can be skipped one-by-one.

@obulat obulat added ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend labels Nov 18, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Nov 18, 2024
@obulat obulat mentioned this issue Nov 18, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant