Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the dark mode snapshot timeout to prevent flakiness #5087

Closed
obulat opened this issue Oct 28, 2024 · 0 comments · Fixed by #5106
Closed

Increase the dark mode snapshot timeout to prevent flakiness #5087

obulat opened this issue Oct 28, 2024 · 0 comments · Fixed by #5106
Assignees
@obulat
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@obulat
Copy link
Contributor

obulat commented Oct 28, 2024

Description

The dark snapshots sometimes don't have enough time to fully re-render, and the VR tests fail.

Reproduction

See error in https://github.com/WordPress/openverse/actions/runs/11510073833/job/32041360267?pr=5075

Additional context
@obulat obulat added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend labels Oct 28, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Oct 28, 2024
@obulat obulat self-assigned this Oct 28, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Oct 28, 2024
@obulat obulat mentioned this issue Oct 29, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Oct 29, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase the timeout before taking a dark snapshot WordPress/openverse
1 participant
@obulat