Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify ES CPU alarm names once they're updated upstream #4882

Closed
AetherUnbound opened this issue Sep 6, 2024 · 0 comments · Fixed by #5245
Closed

Unify ES CPU alarm names once they're updated upstream #4882

AetherUnbound opened this issue Sep 6, 2024 · 0 comments · Fixed by #5245
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow

Comments

@AetherUnbound
Copy link
Collaborator

Description

PR #4858 recently added the second, 90% CPU alarm to the list of alarms we disable during the data refresh. The names for these composite alarms differ and are notably confusing.

After https://github.com/WordPress/openverse-infrastructure/issues/602 (which ideally will unify the alarm names), we'll need to update the data refresh code to disable the correct alarm.

Additional context

From: #4858 (comment)
@AetherUnbound AetherUnbound added ⛔ status: blocked Blocked & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository 🔧 tech: airflow Involves Apache Airflow 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Sep 6, 2024
@openverse-bot openverse-bot moved this to ⛔ Blocked in Openverse Backlog Sep 6, 2024
@dhruvkb dhruvkb mentioned this issue Dec 4, 2024
Merged
8 tasks
@openverse-bot openverse-bot moved this from ⛔ Blocked to 🏗 In Progress in Openverse Backlog Dec 4, 2024
@dhruvkb dhruvkb self-assigned this Dec 4, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 4, 2024
@obulat obulat removed the ⛔ status: blocked Blocked & therefore, not ready for work label Dec 4, 2024
@openverse-bot openverse-bot moved this from ✅ Done to 📋 Backlog in Openverse Backlog Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs 🔧 tech: airflow Involves Apache Airflow
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle new 90% alarms in alarm toggle WordPress/openverse
3 participants
@AetherUnbound @obulat @dhruvkb