Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failure comment is not removed after successful re-run #483

Closed
dhruvkb opened this issue Nov 30, 2022 · 1 comment
Closed

Failure comment is not removed after successful re-run #483

dhruvkb opened this issue Nov 30, 2022 · 1 comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Nov 30, 2022

Problem

When a failing Playwright test is re-run, the comment created by the failed run is left behind. See WordPress/openverse-frontend#2019 for an example.

Expectation

The comment should be removed if a re-run causes a flaky test to pass.
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Nov 30, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 24, 2023

This was fixed in post-monorepo CI + CD improvemnts.

@dhruvkb dhruvkb closed this as completed Nov 24, 2023
@dhruvkb dhruvkb moved this from 📋 Backlog to ✅ Done in Openverse Backlog Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@obulat @dhruvkb