Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI pipeline avoiding running jobs for unrelated changes #478

Closed
krysal opened this issue Dec 21, 2022 · 3 comments
Closed

Optimize CI pipeline avoiding running jobs for unrelated changes #478

krysal opened this issue Dec 21, 2022 · 3 comments
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Milestone

Comments

@krysal
Copy link
Member

krysal commented Dec 21, 2022

Problem

When ones submit a change to the GH actions without altering actual Nuxt code the full CI workflow runs, that includes tasks like creating a preview for Storybook and Tailwind, checking types, and what takes longer, the Playwright tests (E2E, visual regression). For more, many of these works are flaky, it would be much better to prevent them from running early, save CPU time, and speed up the time a PR is ready for review and merge.

Description

I see two options to resolve this:

  • split the current ci workflow into separate ones and use the path config to filter executions by folders being modified or
  • use the dorny/paths-filter or another similar action to avoid running these time-consuming tasks.

Alternatives

Additional context

@krysal krysal added help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Dec 21, 2022
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@krysal krysal added this to the Monorepo milestone Mar 13, 2023
@krysal
Copy link
Member Author

krysal commented Mar 13, 2023

The frontend image build took more time than the rest of the API/Ingestion Server checks in #898 so since this is as well an issue part of an ongoing project I'll put it in the to-do column.

@dhruvkb
Copy link
Member

dhruvkb commented Mar 19, 2023

Is this same as issue #849 fixed by PR #895?

@krysal
Copy link
Member Author

krysal commented Mar 21, 2023

That seems to be the case. I'll close this 👍

@krysal krysal closed this as not planned Won't fix, can't repro, duplicate, stale Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

No branches or pull requests

3 participants