-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize an approach to documenting implementation/project plan changes #4619
Comments
Idea is fine to me, I don't have any reason to block it, and it accomplishes a minimal level of visibility. It's kind of frustrating that it's just duplicating the git history for the file on Some questions need to be answered, though: Should this section go at the top of the IP whenever a change is made? Does it exist when the document is made first-off and include the "Add whatever document" as the first entry? Does it matter? If visibility is important, I guess it does? An alternative that is not an explicit changelog is to expect authors to note where plans have changed as footnotes with links to the relevant PRs and discussions. That's a bit more natural, and leaves less room for out-of-context confusion looking at the changelog at face value. |
Seems fine to me as well. I like that it's separate from the commit history as a change to the plan can be spread across multiple commits, and there can also be commits in the Git history that are associated with smaller inconsequential things (like typo fixes) that do not need to go in a changelog. |
I think this is a great idea! To give some opinions on @sarayourfriend's thoughts:
On formatting, because we automatically link PR numbers already, I think the format could be: ## Changelog
- Date-of-changes - (#ChangesetPRNumber) Summary of changes made to the plan |
Often in the project lifecycle we uncover problems which require alterations to our original planning documents. We want to update the documents to reflect the actual work that needs to happen, but we also want to preserve the original approach and make others aware that the document has changed.
We should develop a standardized method for addressing these updates. I would propose we add a changelog section to the plans like so:
I am open to alternative suggestions! I'll mark this as blocked until at least one @WordPress/openverse-maintainers has reviewed the proposal.
The text was updated successfully, but these errors were encountered: