Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove retired DAGs #4240

Closed
sarayourfriend opened this issue Apr 30, 2024 · 1 comment · Fixed by #4867
Closed

Remove retired DAGs #4240

sarayourfriend opened this issue Apr 30, 2024 · 1 comment · Fixed by #4867
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Apr 30, 2024 •
edited
Loading

Current Situation

We have a handful of "retired" DAGs in the catalog codebase. Some of the older ones especially have non-idiomatic code, and would serve as bad examples of how to write new catalog code.

Suggested Improvement

Delete the retired DAGs directory and remove references to it.

Benefit

No bad code examples, less code, etc.

Additional context

Previous discussion here: #4187 (comment)
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Apr 30, 2024
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Apr 30, 2024
@sarayourfriend sarayourfriend mentioned this issue Apr 30, 2024
Closed
@AetherUnbound
Copy link
Collaborator

Having looked over each of them, I believe the entire folder can be removed.

@sarayourfriend sarayourfriend added the help wanted Open to participation from the community label May 1, 2024
@sarayourfriend sarayourfriend self-assigned this Sep 5, 2024
@sarayourfriend sarayourfriend moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Sep 5, 2024
@sarayourfriend sarayourfriend mentioned this issue Sep 5, 2024
Open
11 tasks
@sarayourfriend sarayourfriend moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Sep 5, 2024
@sarayourfriend sarayourfriend mentioned this issue Sep 5, 2024
Merged
7 tasks
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove retired DAGs from the codebase WordPress/openverse
2 participants
@AetherUnbound @sarayourfriend