Log when source query parameter contains invalid values

[obulat]

Problem

In the API source parameter validation improvements discussion we decided to log when any of the sources in the API request parameters is invalid.

Description

Log whenever one of the sources in the search request is invalid. This is the code that needs to be updated:

openverse/api/api/serializers/media_serializers.py

Lines 655 to 656 in fc38553

	sources = value.lower().split(",")
	sources = [source for source in sources if source in allowed_sources]

We can add the following code:

sources = value.lower().split(",")
original_len = len(sources)
valid_sources = [source for source in sources if source in allowed_sources]
if original_len > len(sources):
    invalid_sources = set(sources).difference(set(valid_sources))
    logger.warn(f"Invalid sources in search query: {invalid_sources}")

Alternatives

We could also save the information about requests and invalid sources in Redis if that would be easier to query.

[manojks1999]

Working on it