Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pnpm/action-setup with Corepack #3807

Closed
dhruvkb opened this issue Feb 19, 2024 · 0 comments · Fixed by #4628
Closed

Replace pnpm/action-setup with Corepack #3807

dhruvkb opened this issue Feb 19, 2024 · 0 comments · Fixed by #4628
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Feb 19, 2024

Problem

We use Corepack to manage pnpm locally and it works really well. But in CI we use pnpm/action-setup to provision pnpm for us.

Description

It should be possible, even simpler, to use Corepack to provision pnpm in CI as well. We should explore that as an option.

Additional context

This idea was provided by @obulat in #3801 (comment). The linked commment includes a code reference too!
@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions labels Feb 19, 2024
@dhruvkb dhruvkb mentioned this issue Feb 19, 2024
Merged
8 tasks
@obulat obulat mentioned this issue Jul 17, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations 🔧 tech: github actions Involves Github Actions
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update pnpm and use corepack WordPress/openverse
1 participant
@dhruvkb