Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop status column from content report tables #3642

Closed
sarayourfriend opened this issue Jan 7, 2024 · 4 comments · Fixed by #4590
Closed

Drop status column from content report tables #3642

sarayourfriend opened this issue Jan 7, 2024 · 4 comments · Fixed by #4590
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Jan 7, 2024

Description

See the following for implementation description and rationale: https://docs.openverse.org/projects/proposals/trust_and_safety/content_report_moderation/20231208-implementation_plan_django_admin_moderator_access.html#backfill-moderationdecision-and-drop-report-status

Blocked by #3641 #4530 and the re-run of the backfillmoderationdecision command.

@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users ⛔ status: blocked Blocked & therefore, not ready for work 🧱 stack: api Related to the Django API labels Jan 7, 2024
@openverse-bot openverse-bot moved this to ⛔ Blocked in Openverse Backlog Jan 7, 2024
@dhruvkb
Copy link
Member

dhruvkb commented Mar 31, 2024

This is not directly related to this project but I wanted to suggest inheriting from OpenLedgerModel in the report models (currently they do not, and instead use a custom field for created_at) which would introduce a migration so it's possible to run both migrations simultaneously to reduce the downtime on that table.

@sarayourfriend
Copy link
Collaborator Author

Good call! Unifying the date columns is a great idea, especially given how small the tables are at the moment. Would it require following the zero downtime migration policy? If so, we should create the issues for each part of the process, maybe as follow-up tasks to the project rather than part of it.

@AetherUnbound
Copy link
Collaborator

This is still blocked by #4530, but can be tackled after that is run!

@sarayourfriend sarayourfriend removed the ⛔ status: blocked Blocked & therefore, not ready for work label Jun 25, 2024
@sarayourfriend sarayourfriend moved this from ⛔ Blocked to 📅 To Do in Openverse Backlog Jun 25, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 📋 Backlog in Openverse Backlog Jun 25, 2024
@krysal krysal added the ⛔ status: blocked Blocked & therefore, not ready for work label Jun 25, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to ⛔ Blocked in Openverse Backlog Jun 25, 2024
@krysal
Copy link
Member

krysal commented Jun 28, 2024

The backfill was run between Tuesday and Wednesday so this is unblocked.

@krysal krysal removed the ⛔ status: blocked Blocked & therefore, not ready for work label Jun 28, 2024
@openverse-bot openverse-bot moved this from ⛔ Blocked to 📋 Backlog in Openverse Backlog Jun 28, 2024
@krysal krysal self-assigned this Jul 1, 2024
@openverse-bot openverse-bot moved this from 📋 Backlog to 📅 To Do in Openverse Backlog Jul 1, 2024
@openverse-bot openverse-bot moved this from 📅 To Do to 🏗 In Progress in Openverse Backlog Jul 1, 2024
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants