Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thumbnail rate limit incorrectly applied to non-thumbnail routes #3485

Closed
sarayourfriend opened this issue Dec 7, 2023 · 0 comments · Fixed by #3486
Closed

Thumbnail rate limit incorrectly applied to non-thumbnail routes #3485

sarayourfriend opened this issue Dec 7, 2023 · 0 comments · Fixed by #3486
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

Description

The thumbnail throttle classes are in the default list of throttles, which are applied to all routes with no explicit throttle classes (which is most of our routes, including search). This means that search requests incorrectly count towards thumbnail requests count, from a throttling perspective.

Reproduction

  1. Visit https://api.openverse.engineering/v1/ and check out the response headers and see that `x-ratelimit-limit-anon_thumbnail` is incorrectly present, meaning that throttle class was applied to the request.
@sarayourfriend sarayourfriend added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: api Related to the Django API labels Dec 7, 2023
@sarayourfriend sarayourfriend self-assigned this Dec 7, 2023
@openverse-bot openverse-bot moved this to 📋 Backlog in Openverse Backlog Dec 7, 2023
@sarayourfriend sarayourfriend moved this from 📋 Backlog to 🏗 In Progress in Openverse Backlog Dec 7, 2023
@openverse-bot openverse-bot moved this from 🏗 In Progress to ✅ Done in Openverse Backlog Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant