Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API memory leak #3028

Closed
sarayourfriend opened this issue Sep 15, 2023 · 4 comments
Closed

API memory leak #3028

sarayourfriend opened this issue Sep 15, 2023 · 4 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API

Comments

@sarayourfriend
Copy link
Collaborator

Description

The API's memory consumption pattern changed significantly in the last month.

image

This corresponds with the switch over to ES 8 in production and with this changelog: https://docs.openverse.org/changelogs/api/2023.08.28.20.43.01.html

The changelog doesn't have any changes that seem like they could possibly be related, so I suspect this has something to do with the ES 8 switch.

First thing that comes to mind is that we forgot to update the ES-py client version to match the cluster.

I'll get a PR for that up ASAP and then run a memory analysis locally to see if I can identify a leak.

Marked as critical because we need to resolve this before the ASGI switch.

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: api Related to the Django API labels Sep 15, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Sep 15, 2023
@sarayourfriend sarayourfriend moved this from 📋 Backlog to 🏗 In progress in Openverse Backlog Sep 18, 2023
@sarayourfriend sarayourfriend self-assigned this Sep 18, 2023
@sarayourfriend
Copy link
Collaborator Author

I've assigned this to myself as I'm working on the ES client upgrade, but will need to hand this off if that doesn't solve the issue.

@sarayourfriend sarayourfriend removed their assignment Sep 19, 2023
@sarayourfriend
Copy link
Collaborator Author

We deployed the ES client upgrade 12 hours ago, but it has not solved the memory leak. @obulat identified that it is still happening in production.

I unassigned myself the issue and am pinging @WordPress/openverse-api to hand off to someone else.

@dhruvkb
Copy link
Member

dhruvkb commented Sep 27, 2023

I'm lowering the priority of this issue to high, because we're not actively working on this till the ASGI migration has been completed.

@dhruvkb dhruvkb added the 🟧 priority: high Stalls work on the project or its dependents label Sep 27, 2023
@AetherUnbound
Copy link
Collaborator

image
We believe this issue has been mitigated for now, as completed by the efforts of #3047 and #3048

@github-project-automation github-project-automation bot moved this from 📅 To do to ✅ Done in Openverse Backlog Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

No branches or pull requests

3 participants