Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hvac dependency from API #2894

Closed
sarayourfriend opened this issue Aug 25, 2023 · 0 comments · Fixed by #3003
Closed

Remove hvac dependency from API #2894

sarayourfriend opened this issue Aug 25, 2023 · 0 comments · Fixed by #3003
Assignees
@rwidom
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🐍 tech: python Involves Python

Comments

@sarayourfriend
Copy link
Collaborator

Problem

hvac is an installed dependency but is not used.

Description

Remove hvac from api/pipfile then run pipenv install in api directory and commit the lockfile changes.

Confirm unit tests work by running the following from repository root:

$ just dc build web
$ just api/test
@sarayourfriend sarayourfriend added help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🐍 tech: python Involves Python 🧱 stack: api Related to the Django API labels Aug 25, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Aug 25, 2023
@sarayourfriend sarayourfriend changed the title Remove hvac dependency Remove hvac dependency from API Aug 25, 2023
@AetherUnbound AetherUnbound moved this from 📋 Backlog to 📅 To do in Openverse Backlog Aug 29, 2023
@rwidom rwidom assigned rwidom and unassigned rwidom Sep 9, 2023
@rwidom rwidom mentioned this issue Sep 10, 2023
Merged
8 tasks
@rwidom rwidom self-assigned this Sep 10, 2023
@github-project-automation github-project-automation bot moved this from 📅 To do to ✅ Done in Openverse Backlog Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwidom rwidom

Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: api Related to the Django API 🐍 tech: python Involves Python
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

remove hvac dependency from API WordPress/openverse
2 participants
@rwidom @sarayourfriend