-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New popover and popover item #2839
Comments
Adding the |
@fcoveram, we have a |
Thanks for the response. Now I understand. The content switcher popover doesn't need any change. But the content header's menu does need to be updated. I guess that is for a new PR. I put the site menu mockup and the popover in context in the Design Library, and below a screenshot of the same element. The active state has |
Closing this issue as both popover components were integrated successfully. |
Description
As part of the design changes agreed upon in #460, we need to update the styles of Popover and Popover item.
Popover
(description from #460)
The popover follows the Modal implemented in Gutenberg.
size: small
,style: transparent
,color: gray
.4px
in all breakpoints.XS
andSM
, the container has a padding of16px
and a margin of32px
.24px
and amax-width
(TBD).You can find the popover structure in the Design Library, and the Metasearch case in its respective design file.
Popover item
In line with the improvements made in #415, this component inherits the fixed height and has three variants for different interaction cases. In #460 designs, the variant used is
Label
.You can find the Popover item component in the Design Library. You will also see a Popover header component in the same section that is not part of #460 changes and will be requested in a different ticket.
Additional context
Since popover item is also used in VRecentSearches component, I will create a new issue requesting its implementation.
The text was updated successfully, but these errors were encountered: