Remove implicit @testing-library get* assertions: v-modal.spec.js

[sarayourfriend]

Current Situation

See #2198 for description of issue.

Suggested Improvement

Remove the expect(...).not.toThrow() wrapper and use explicit assertions for each expected element.

Example transformations:

expect(() => {
  screen.getByRole("button") // throws if not present
  screen.getByRole("dialog") // throws if not present
}).not.toThrow()

should be

expect(screen.findByRole("button")).toBeInTheDocument()
expect(screen.findByRole("dialog")).toBeInTheDocument()

Lines that need to be changed

openverse/frontend/test/unit/specs/components/v-modal.spec.js

Line 115 in 364d07a

expect(() => screen.getByText(/custom initial focus/i)).not.toThrow()

Benefit

See #2198