Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VPopover story is broken #2215

Closed
sarayourfriend opened this issue May 29, 2023 · 2 comments · Fixed by #2447
Closed

VPopover story is broken #2215

sarayourfriend opened this issue May 29, 2023 · 2 comments · Fixed by #2447
Assignees
@obulat
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend

Comments

@sarayourfriend
Copy link
Collaborator

Description

https://docs.openverse.org/storybook/?path=/story/components-vpopover--default-story is broken with the error message below:

state.rects is undefined

detectOverflow@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:98616
detectMaxHeight@https://docs.openverse.org/storybook/main.97df8a96.iframe.bundle.js:2:1543821
./src/components/VPopover/VPopoverContent.vue/usePopper/<@https://docs.openverse.org/storybook/main.97df8a96.iframe.bundle.js:2:1543993
invokeWithErrorHandling@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:2576284
call@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:2572334
../node_modules/.pnpm/[email protected]/node_modules/vue/dist/vue.js/</factory/doWatch/watcher.run@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:2573785
flushSchedulerQueue@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:2569913
../node_modules/.pnpm/[email protected]/node_modules/vue/dist/vue.js/</factory/nextTick/<@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:2577873
flushCallbacks@https://docs.openverse.org/storybook/vendors~main.2636c955.iframe.bundle.js:2:2577061
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels May 29, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog May 29, 2023
@sarayourfriend sarayourfriend mentioned this issue May 30, 2023
Closed
@sarayourfriend
Copy link
Collaborator Author

This must also fix the VItemGroup sub-story "popover".

@obulat
Copy link
Contributor

obulat commented Jun 19, 2023

This error message is such a red herring! The problem with this story, just as with the VItemGroup, is that the buttons there don't have required variant and size parameters.

@obulat obulat mentioned this issue Jun 19, 2023
Merged
8 tasks
@zackkrida zackkrida moved this from 📋 Backlog to 🏗 In progress in Openverse Backlog Jun 20, 2023
@obulat obulat self-assigned this Jun 20, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Openverse Backlog Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a popover storybook test WordPress/openverse
2 participants
@obulat @sarayourfriend