Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing improvements in All content's <header> area #2079

Closed
fcoveram opened this issue May 11, 2023 · 0 comments · Fixed by #2084
Closed

Spacing improvements in All content's <header> area #2079

fcoveram opened this issue May 11, 2023 · 0 comments · Fixed by #2084
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend

Comments

@fcoveram
Copy link
Contributor

fcoveram commented May 11, 2023

Problem

The "All content" results page has an unbalanced space in the result label area, between header and content links, that makes the layout look odd while resting space for more result items at the same time.

Here are two screenshots highlighting the area in blue.

Screenshots of Openverse results in mobile and desktop. Header area is highlighted

And here screenshots for all breakpoints.

Screenshots of Openverse results in all breakpoints. Header area is highlighted

Description

The following spacing and text style changes can improve the layout:

  • Reducing the line height of Heading 1 text style from 1.3 to 1. This library change will be updated in Figma's Design Library as well.
  • Apply Heading 2 text style to <h1> on md breakpoint.
  • Change the paddings of <header> element where h1 is placed to be 8px for top and 24px for bottom.
  • Hide the <header> on xs and sm as the element adds unnecessary space. Here is a screenshot from Firefox's inspector.

I updated all layouts in Views page in the Design Library for reference.

Additional context

This request is in line with the improvements requested in #2078 that were identified during #1178

@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels May 11, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog May 11, 2023
@fcoveram fcoveram added 🕹 aspect: interface Concerns end-users' experience with the software 🧱 stack: frontend Related to the Nuxt frontend labels May 11, 2023
@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label May 12, 2023
@obulat obulat self-assigned this May 12, 2023
@obulat obulat added the 🟨 priority: medium Not blocking but should be addressed soon label May 12, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants