Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR review reminders DAG does not handle base branches other than main #1863

Closed
sarayourfriend opened this issue Apr 21, 2023 · 0 comments · Fixed by #1900
Closed

PR review reminders DAG does not handle base branches other than main #1863

sarayourfriend opened this issue Apr 21, 2023 · 0 comments · Fixed by #1900
Assignees
@sarayourfriend
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs

Comments

@sarayourfriend
Copy link
Collaborator

Airflow log link

https://airflow.openverse.engineering/log?execution_date=2023-04-20T00%3A00%3A00%2B00%3A00&task_id=pr_review_reminder_operator&dag_id=pr_review_reminders&map_index=-1

Note: Airflow is currently only accessible to maintainers & those given
access. If you would like access to Airflow, please reach out to a member of
@WordPress/openverse-maintainers.

Description

404 Client Error: Not Found for url: https://api.github.com/repos/WordPress/openverse/branches/main_old/protection

We need better handling for different base branches. Should we ignore PRs that don't target main?

DAG status

No change to the DAG status.
@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Apr 21, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 21, 2023
@sarayourfriend sarayourfriend changed the title <Replace this with actual title> PR review reminders DAG does not handle base branches other than main Apr 21, 2023
@sarayourfriend sarayourfriend self-assigned this Apr 24, 2023
@sarayourfriend sarayourfriend mentioned this issue Apr 26, 2023
Merged
7 tasks
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarayourfriend sarayourfriend

Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
1 participant
@sarayourfriend