-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Europeana endpoint and accomodate v2 API changes #1727
Comments
@WordPress/openverse-maintainers as far as I can tell the Europeana API is still backwards-compatible with the fields we are using. Is this GitHub issue the only reason our provider DAG for them is still disabled? Do we also need an API key? It would be nice to be able to run this while we await a contributor updating the script. |
@zackkrida I just checked and it looks like we are also missing an API key for Europeana. I'll make a ticket for that; once we have that I agree, we should let the script run as it does seem to be backwards compatible for now. |
@sarayourfriend it looks like you actually closed this too in WordPress/openverse-catalog#821 😮 Is that correct? |
I copied the existing URL, didn't make any changes there: https://github.com/WordPress/openverse-catalog/pull/821/files#diff-30cf1cf9d75f477a0be73d1f788cc9eff37480c1a884bb444f849dce71b75205L33 |
D'oh, missed that! I didn't read this issue carefully enough either 🙂 |
Current Situation
https://www.europeana.eu/api/v2/search.json
endpoint. However Europeana has changed it's API endpoint tohttps://api.europeana.eu/
to better manage traffic. This change has been noted in their API docs here. Corresponding change should be made in the present API integration script.Suggested Improvement
In the Europeana provider script, change value of
ENDPOINT
tohttps://api.europeana.eu/
. Update the provider script and test suite with new fields according to v2 API. Ensure that the scripts run properly after making the changes.Benefit
Currently the old endpoint is still working. However this might change. Accommodating above changes will ensure that Europeana integration is updated.
The text was updated successfully, but these errors were encountered: