Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Europeana endpoint and accomodate v2 API changes #1727

Closed
dravadhis opened this issue Jun 21, 2021 · 5 comments · Fixed by WordPress/openverse-catalog#974
Closed

Update Europeana endpoint and accomodate v2 API changes #1727

dravadhis opened this issue Jun 21, 2021 · 5 comments · Fixed by WordPress/openverse-catalog#974
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon

Comments

@dravadhis
Copy link

Current Situation

  1. The current integration of the Europeana API uses the https://www.europeana.eu/api/v2/search.json endpoint. However Europeana has changed it's API endpoint to https://api.europeana.eu/ to better manage traffic. This change has been noted in their API docs here. Corresponding change should be made in the present API integration script.
  2. Some fields have been changed in v2 API. The backward compatibility of v1 API may be stopped anytime. Hence the API script needs to be modified according to the new fields. ( list of modified fields)
  3. Above changes also need to be made in the test files wherever required.

Suggested Improvement

In the Europeana provider script, change value of ENDPOINT to https://api.europeana.eu/. Update the provider script and test suite with new fields according to v2 API. Ensure that the scripts run properly after making the changes.

Benefit

Currently the old endpoint is still working. However this might change. Accommodating above changes will ensure that Europeana integration is updated.

@zackkrida zackkrida added help wanted Open to participation from the community 🏁 status: ready for work Ready for work 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Jun 22, 2021
@zackkrida zackkrida added the good first issue New-contributor friendly label Aug 10, 2021
@AetherUnbound AetherUnbound self-assigned this Oct 19, 2021
@AetherUnbound AetherUnbound added 🟩 priority: low Low priority and doesn't need to be rushed and removed 🟧 priority: high Stalls work on the project or its dependents labels Mar 22, 2022
@zackkrida
Copy link
Member

@WordPress/openverse-maintainers as far as I can tell the Europeana API is still backwards-compatible with the fields we are using. Is this GitHub issue the only reason our provider DAG for them is still disabled? Do we also need an API key? It would be nice to be able to run this while we await a contributor updating the script.

@stacimc
Copy link
Collaborator

stacimc commented Jun 24, 2022

@zackkrida I just checked and it looks like we are also missing an API key for Europeana. I'll make a ticket for that; once we have that I agree, we should let the script run as it does seem to be backwards compatible for now.

@AetherUnbound AetherUnbound removed their assignment Jul 12, 2022
@AetherUnbound AetherUnbound added 🟨 priority: medium Not blocking but should be addressed soon and removed good first issue New-contributor friendly 🏁 status: ready for work Ready for work 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 19, 2022
@AetherUnbound
Copy link
Collaborator

@sarayourfriend
Copy link
Collaborator

@AetherUnbound
Copy link
Collaborator

D'oh, missed that! I didn't read this issue carefully enough either 🙂

@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants