Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove thumbnail field for images from the catalog #1561

Closed
1 of 4 tasks
obulat opened this issue May 20, 2022 · 3 comments · Fixed by WordPress/openverse-catalog#526
Closed
1 of 4 tasks

Remove thumbnail field for images from the catalog #1561

obulat opened this issue May 20, 2022 · 3 comments · Fixed by WordPress/openverse-catalog#526
Assignees
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon

Comments

@obulat
Copy link
Contributor

obulat commented May 20, 2022

Current Situation

We get the thumbnail URL field from the providers but do not use it because we use the thumbnail proxy instead.

Suggested Improvement

We should stop retrieving thumbnails from providers.
There are several things that need to be addressed here:

  • Remove the thumbnail from provider scripts.
  • We probably do not need to remove thumbnail from the common columns (TSV and DB) as audio (and maybe other media types) use them. I think it would be easier to set the image thumbnails to NULL.
  • Clean up the database?

Benefit

Slightly-improved performance and less data to store, data consistency.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels May 20, 2022
@obulat obulat mentioned this issue May 20, 2022
29 tasks
@sarayourfriend
Copy link
Collaborator

Interesting! Would removing this have any implications for video or 3d models (not sure if models have thumbnails but I hope so!)

@obulat
Copy link
Contributor Author

obulat commented May 20, 2022

Well, I think we should leave the thumbnail field in the catalog as the field that is used for all types of media, but set it to null for images. We will need to investigate whether we want to use the thumbnails that are provided by the providers as we do with audio, or generate them just as we do with images.

@sarayourfriend
Copy link
Collaborator

Well, I think we should leave the thumbnail field in the catalog as the field that is used for all types of media, but set it to null for images. We will need to investigate whether we want to use the thumbnails that are provided by the providers as we do with audio, or generate them just as we do with images.

Okay! That makes sense 👍

@obulat obulat added ✨ goal: improvement Improvement to an existing user-facing feature and removed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels May 20, 2022
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
@dhruvkb dhruvkb added this to the Data normalization milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants