Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Github issues to re-enable Slack alerts in check_silenced_dags DAG #1483

Open
1 task
stacimc opened this issue Aug 10, 2022 · 0 comments
Open
1 task
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs

Comments

@stacimc
Copy link
Collaborator

stacimc commented Aug 10, 2022

Problem

The check_silenced_dags DAG validates the silenced_slack_alerts configuration by checking that each silenced DAG is associated to an open GH issue. If the issue has been closed, the DAG will send a Slack alert indicating that the DAG ought to have error reporting turned back on.

Quote @sarayourfriend from this comment on WordPress/openverse-catalog#643:

It'd be nice if this created a GitHub issue or something that could actually be assigned and tracked or have the maintainers pinged. Or maybe even just left a comment on the issue itself like "Please un-silence the DAG errors". Or maybe both, a new issue and a ping on the old, with the new issue just tracking the work of actually updating the prod configuration.

Just worried a slack ping could easily get lost (especially if lots of people are on vacation or distracted by something else, for example) in a way that a GitHub issue won't, as it acts more like a formal "todo" item.

Description

This would be a fantastic addition to make sure that Slack pings don't get lost. I think opening a new high priority GH issue to track re-enabling alerts is warranted, because by definition we only expect this to happen when an issue was resolved but someone forgot to turn alerts back on.

Implementation

  • 🙋 I would be interested in implementing this feature.
@stacimc stacimc added 🌟 goal: addition Addition of new feature ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Aug 10, 2022
@sarayourfriend sarayourfriend added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Aug 10, 2022
@stacimc stacimc added 🟨 priority: medium Not blocking but should be addressed soon and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🌟 goal: addition Addition of new feature labels Aug 11, 2022
@obulat obulat added the 🧱 stack: catalog Related to the catalog and Airflow DAGs label Feb 24, 2023
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Status: 📋 Backlog
Development

No branches or pull requests

3 participants