Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a HEAD request for WordPressDataIngester::_get_filesize #1377

Closed
1 task
AetherUnbound opened this issue Oct 25, 2022 · 0 comments · Fixed by WordPress/openverse-catalog#865
Closed
1 task

Use a HEAD request for WordPressDataIngester::_get_filesize #1377

AetherUnbound opened this issue Oct 25, 2022 · 0 comments · Fixed by WordPress/openverse-catalog#865
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ⛔ status: blocked Blocked & therefore, not ready for work 🐍 tech: python Involves Python

Comments

@AetherUnbound
Copy link
Collaborator

Description

Similar to #1493 and #1578, it would be nice to use a HEAD request when retrieving the content length of the images in the WordPress Photo Directory provider script:

https://github.com/WordPress/openverse-catalog/blob/825e478bf65e4807ca47fdcd88c9f0af6472cece/openverse_catalog/dags/providers/provider_api_scripts/wordpress.py#L123-L127

Additional context

Soft blocked by #1579

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added good first issue New-contributor friendly help wanted Open to participation from the community ⛔ status: blocked Blocked & therefore, not ready for work 🐍 tech: python Involves Python 💻 aspect: code Concerns the software code in the repository 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 25, 2022
@AetherUnbound AetherUnbound mentioned this issue Apr 17, 2023
Closed
1 task
@twstokes twstokes mentioned this issue Nov 10, 2022
Merged
7 tasks
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed ⛔ status: blocked Blocked & therefore, not ready for work 🐍 tech: python Involves Python
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add HEAD requests support to DelayedRequester twstokes/openverse-catalog
1 participant
@AetherUnbound