Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate image thumbnail column #1359

Closed
1 task
AetherUnbound opened this issue Nov 22, 2022 · 1 comment · Fixed by WordPress/openverse-catalog#903
Closed
1 task

Reinstate image thumbnail column #1359

AetherUnbound opened this issue Nov 22, 2022 · 1 comment · Fixed by WordPress/openverse-catalog#903
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents

Comments

@AetherUnbound
Copy link
Collaborator

Description

The image thumbnail column was removed from the ImageStore interface (and several providers) as part of WordPress/openverse-catalog#526. Since that time, we have come to a better understanding of the data stack as a whole and would like to continue using upstream-provided thumbnails where possible to reduce load on our own thumbnail service. This Make WP post provides some additional context: https://make.wordpress.org/openverse/2022/10/25/storing-provider-supplied-thumbnails/

After discussing this on the post, we have come to the decision to reinstate the thumbnail field on ImageStore and start using the thumbnail column in Postgres once more. We should also go back and re-add the thumbnail ingestion to the provider scripts that were modified in WordPress/openverse-catalog#526.

Once this is complete, this will also unblock #1401, #1389, and #1450.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added data normalization help wanted Open to participation from the community 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Nov 22, 2022
@AetherUnbound
Copy link
Collaborator Author

I've set this issue as "high" because it's blocking a few other issues. If medium makes more sense for this please go ahead and change it!

@krysal krysal self-assigned this Dec 1, 2022
@obulat obulat transferred this issue from WordPress/openverse-catalog Apr 17, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Apr 17, 2023
@obulat obulat moved this from 📋 Backlog to ✅ Done in Openverse Backlog Apr 24, 2023
@dhruvkb dhruvkb added this to the Data normalization milestone Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix help wanted Open to participation from the community 🟧 priority: high Stalls work on the project or its dependents
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants