diff --git a/packages/eslint-plugin/package.json b/packages/eslint-plugin/package.json index a51650be75e..e26f78b8b88 100644 --- a/packages/eslint-plugin/package.json +++ b/packages/eslint-plugin/package.json @@ -20,7 +20,7 @@ "eslint-plugin-eslint-comments": "^3.2.0", "eslint-plugin-import": "^2.28.1", "eslint-plugin-jest": "^27.2.3", - "eslint-plugin-playwright": "^0.16.0", + "eslint-plugin-playwright": "^0.21.0", "eslint-plugin-tsdoc": "^0.2.17", "eslint-plugin-unicorn": "^48.0.1", "eslint-plugin-vue": "^9.17.0", diff --git a/packages/eslint-plugin/src/configs/index.ts b/packages/eslint-plugin/src/configs/index.ts index 16c8458d750..8baabe7daa8 100644 --- a/packages/eslint-plugin/src/configs/index.ts +++ b/packages/eslint-plugin/src/configs/index.ts @@ -77,6 +77,8 @@ export const project: TSESLint.Linter.Config = { rules: { // Superseded by `@openverse/no-unexplained-disabled-test` "playwright/no-skipped-test": "off", + // Duplicates TypeScript functionality. All our Playwright tests are in TypeScript and type checks will already catch non-string titles. + "playwright/valid-title": "off", }, settings: { playwright: { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 12946e7cdc4..b2d72b6a0ee 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -344,8 +344,8 @@ importers: specifier: ^27.2.3 version: 27.2.3(@typescript-eslint/eslint-plugin@6.5.0)(eslint@8.48.0)(jest@29.6.4)(typescript@5.2.2) eslint-plugin-playwright: - specifier: ^0.16.0 - version: 0.16.0(eslint-plugin-jest@27.2.3)(eslint@8.48.0) + specifier: ^0.21.0 + version: 0.21.0(eslint-plugin-jest@27.2.3)(eslint@8.48.0) eslint-plugin-tsdoc: specifier: ^0.2.17 version: 0.2.17 @@ -11915,8 +11915,8 @@ packages: natural-compare: 1.4.0 dev: true - /eslint-plugin-playwright@0.16.0(eslint-plugin-jest@27.2.3)(eslint@8.48.0): - resolution: {integrity: sha512-DcHpF0SLbNeh9MT4pMzUGuUSnJ7q5MWbP8sSEFIMS6j7Ggnduq8ghNlfhURgty4c1YFny7Ge9xYTO1FSAoV2Vw==} + /eslint-plugin-playwright@0.21.0(eslint-plugin-jest@27.2.3)(eslint@8.48.0): + resolution: {integrity: sha512-Y6qwguE9L6LB1JCsnPKaHbo+Z4X8/MngD82N0NkwiZ0ch0UVc4Oc2ZqmxanFxftIddnvwtNNlzUezglLlzUzKA==} peerDependencies: eslint: '>=7' eslint-plugin-jest: '>=25' @@ -11928,6 +11928,7 @@ packages: dependencies: eslint: 8.48.0 eslint-plugin-jest: 27.2.3(@typescript-eslint/eslint-plugin@6.5.0)(eslint@8.48.0)(jest@29.6.4)(typescript@5.2.2) + globals: 13.24.0 dev: false /eslint-plugin-tsdoc@0.2.17: @@ -13092,6 +13093,13 @@ packages: dependencies: type-fest: 0.20.2 + /globals@13.24.0: + resolution: {integrity: sha512-AhO5QUcj8llrbG09iWhPU2B204J1xnPeL8kQmVorSsy+Sjj1sk8gIyh6cUocGmH4L0UuhAJy+hJMRA4mgA4mFQ==} + engines: {node: '>=8'} + dependencies: + type-fest: 0.20.2 + dev: false + /globals@9.18.0: resolution: {integrity: sha512-S0nG3CLEQiY/ILxqtztTWH/3iRRdyBLw6KMDxnKMchrtbj2OFmehVh0WUCfW3DUrIgx/qFrJPICrq4Z4sTR9UQ==} engines: {node: '>=0.10.0'}