From 6a749c9dee695a54e2b2502359361e7530149ffa Mon Sep 17 00:00:00 2001 From: Olga Bulat Date: Tue, 2 May 2023 21:55:52 +0300 Subject: [PATCH] Apply changes from code review --- catalog/tests/dags/common/licenses/test_licenses.py | 7 +++++++ .../providers/provider_api_scripts/test_brooklyn_museum.py | 6 ------ 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/catalog/tests/dags/common/licenses/test_licenses.py b/catalog/tests/dags/common/licenses/test_licenses.py index bc7146f5164..05c2a72ca3b 100644 --- a/catalog/tests/dags/common/licenses/test_licenses.py +++ b/catalog/tests/dags/common/licenses/test_licenses.py @@ -112,6 +112,13 @@ def test_get_valid_cc_url_nones_missing_url(mock_rewriter): assert actual_url is None +def test_get_valid_cc_url_rewrites_urls_from_special_cases(): + actual_url = licenses._get_valid_cc_url( + "https://creativecommons.org/share-your-work/public-domain/cc0/" + ) + assert actual_url == "https://creativecommons.org/publicdomain/zero/1.0/" + + def test_get_valid_cc_url_uses_rewritten_url(monkeypatch): expected_url = "https://creativecommons.org/licenses/licenses/by/1.0/" diff --git a/catalog/tests/dags/providers/provider_api_scripts/test_brooklyn_museum.py b/catalog/tests/dags/providers/provider_api_scripts/test_brooklyn_museum.py index 8f218850399..7cc0a6d40b1 100644 --- a/catalog/tests/dags/providers/provider_api_scripts/test_brooklyn_museum.py +++ b/catalog/tests/dags/providers/provider_api_scripts/test_brooklyn_museum.py @@ -55,12 +55,6 @@ def test_get_data_from_response(resource_name, expected): assert actual == expected -def test_docstring_example(): - json_func_ex = make_resource_json_func("brooklynmuseum") - json_dict = json_func_ex("cc_license_info.json") - assert json_dict["public_name"] == "Creative Commons-BY" - - @pytest.mark.parametrize( "batch_objects_name, object_data_name, expected_count", [