Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement safe Vale styles #6

Open
4 tasks
sarayourfriend opened this issue Nov 1, 2023 · 3 comments
Open
4 tasks

Implement safe Vale styles #6

sarayourfriend opened this issue Nov 1, 2023 · 3 comments
Assignees

Comments

@sarayourfriend
Copy link
Collaborator

sarayourfriend commented Nov 1, 2023

In WordPress/openverse#3065 we attempted to add Vale to the monorepo. However, because Vale relies on locally defining styles, its usage inherently introduces lists of sensitive terms into the repository. We've worked hard to avoid that, and we can do so by moving the Vale configuration into this repository, and then using a docker image to run Vale in pre-commit to check in CI.

To do that, we'll follow this procedure:

@sarayourfriend
Copy link
Collaborator Author

@ngken0995 would you like me to assign you to this issue?

@ngken0995
Copy link
Collaborator

@sarayourfriend Yes, I would like to be assign to this issue. Looking forward to working on it.

@sarayourfriend
Copy link
Collaborator Author

sarayourfriend commented Nov 1, 2023

Great! Assigned. If you comment on the other issues I can assign them to you as well, but it's not as important in this repository, not much happens in here usually 🙂

As for picking the styles, go with what you think is best. I was thinking more about the lists from alex especially and I'm sceptical we need to lint for violent slurs (for example). It's never been an issue that someone opened a PR with them in it and if they did we'd close the PR immediately for being in violation of the WordPress code of conduct anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants