Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add bundle size reporting to PRs #567

Closed
1 task
sarayourfriend opened this issue Jan 3, 2022 · 0 comments · Fixed by #1332
Closed
1 task

Add bundle size reporting to PRs #567

sarayourfriend opened this issue Jan 3, 2022 · 0 comments · Fixed by #1332
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed

Comments

@sarayourfriend
Copy link
Contributor

Problem

Currently if we add or update a dependency, we don't have any automatic insight into how it effects our bundle sizes. Especially when adding a new dependency, this can be helpful in narrowing down options or debugging sudden unexpected increases in bundle sizes.

Description

Let's add a bundle size analysis step to the CI similar to how Gutenberg has it. Here is an example comment from a PR where this feedback was helpful for avoiding a sudden unexpected increase in bundle sizes.

We can copy the strategy used by Gutenberg in this workflow action.

The preactjs@compressed-size action should still work fine for us even though we're not using preact or React. It just does a Webpack bundle analysis to get the data.

If for whatever it doesn't work for us then we'll need to explore a bespoke strategy. I tried searching around for nuxt specific solutions but there don't appear to be any but we could build off of nuxt build --analyze --spa --no-generate and use the generated json stats output in the ./.nuxt/stats folder.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Jan 3, 2022
@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants