Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Some images don't have "Related images" but the header for the section is still displayed #1719

Closed
1 task
krysal opened this issue Aug 22, 2022 · 9 comments · Fixed by #1941
Closed
1 task
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon

Comments

@krysal
Copy link
Member

krysal commented Aug 22, 2022

Problem

One of our current featured images (the one shown on the homepage) appear to have no related images after some modifications in the API endpoint (WordPress/openverse-api#865). This is likely happening with more images, so will be better to hide the header when the section is empty.

The details page of this featured image:
https://search-production.openverse.engineering/image/648b566f-0228-4819-83d5-8f1d324ec06d

Screenshot 2022-08-22 at 15-06-24 File The victorious English 400 m  women's relay swimming team at Wellcome V0048555 Openverse

Alternatives

This is open to alternatives while is reworked on the API.

Implementation

  • 🙋 I would be interested in implementing this feature.
@krysal krysal added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository good first issue New-contributor friendly help wanted Open to participation from the community labels Aug 22, 2022
@zackkrida
Copy link
Member

Just to confirm, there are definitely no related images returned by the API endpoint, interesting:

https://api.openverse.engineering/v1/images/648b566f-0228-4819-83d5-8f1d324ec06d/related/

@obulat
Copy link
Contributor

obulat commented Aug 23, 2022

I wonder if it's cache related. Checking now, I can see both the frontend and the API results for this link.

@zackkrida
Copy link
Member

Ah very strange, I can now as well. I don't think it's the cache though, because I've been testing this by appending unique query strings. Something else may be going on in the API 🤔

@dhruvkb
Copy link
Member

dhruvkb commented Aug 24, 2022

In any case, given that there is a possibility that we might have images that are unrelated to anything else, we should add the check to not show the heading unless there is content to go below it.

@shreyanshmalvya
Copy link
Contributor

Just visited the link given in the issue, but it shows Related Images to me.

image

@krysal
Copy link
Member Author

krysal commented Aug 25, 2022

@shreyanshmalvya Yes, it was something that happened for a few moments, we need to find out why does that happen but also to hide the section when there are no related images available.

Are you interested in working on this? :)

@shreyanshmalvya
Copy link
Contributor

@krysal Yes, I am, I even checked out the code to find any errors.

@0kyn
Copy link
Contributor

0kyn commented Oct 27, 2022

Hello @shreyanshmalvya do you still plan to work on this issue? Or may I take look at it?

@dhruvkb
Copy link
Member

dhruvkb commented Oct 28, 2022

@0kyn, it's been 2 months since @shreyanshmalvya commented. Feel free to take this up.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants