Providers links from Source page not working properly

[krysal]

Description

The links from the Source column in the table of the Sources page return empty results in the search page. The issue here is that this is going to the general search (all media) which doesn't support the source filter and there is also no search term, this table was created when images were the only media available.

Reproduction

1. Go to https://wordpress.org/openverse/sources or https://search-staging.openverse.engineering/sources and click in any source
2. See the empty search result page.

Expectation

The links should lead to the image (or audio when added those sources to the table) search filtered by the clicked source, and therefore display a non-empty results page.

Resolution

• 🙋 I would be interested in resolving this bug.

[sarayourfriend]

The links should lead to the image (or audio when added those sources to the table) search filtered by the clicked source, and therefore display a non-empty results page.

What should we do with providers like Wikimedia? 🤔

[krysal]

Good question, probably have to add it twice. I guess we need an extra column in the table to indicate the media type of the providers.

[sarayourfriend]

The table data is based off the ContentProvider's API right?

https://github.com/WordPress/openverse-api/blob/a7955c86d43bff504e8d41454f68717d79dd3a44/api/catalog/api/models/models.py#L29-L32

It doesn't look like it allows for "mixed" provider types, would we just add Wikimedia there twice?

Update: Oh dear, I should have just read the doc string 😅

https://github.com/WordPress/openverse-api/blob/a7955c86d43bff504e8d41454f68717d79dd3a44/api/catalog/api/models/models.py#L7-L19

[zackkrida]

@WordPress/openverse-frontend We should remove these links while they're not working, as a hotfix for a production bug. I created a new issue to discuss next steps after that.